Re: [PATCH] UBIFS: fill f_fsid

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Woodhouse
Date: Monday, September 1, 2008 - 2:43 am

On Sun, 2008-08-31 at 17:52 +0300, Artem Bityutskiy wrote:

I think you mean a 16-byte UUID, not 16-bit?


For btrfs I xor the first 64 bits with the second 64 bits, and put
_that_ into f_fsid. You're just putting the first 64 bits in and
ignoring the second 64 bits. Neither is really _better_ than the other;
you just alter the circumstances in which you get collisions. But I
suppose we might as well be consistent about how we do it?

(Actually I XOR in the root object ID for the subvol too, but you don't
need to worry about that).

Alternatively, there's space in the struct statfs to export a couple
more uint32_ts, and thus the _whole_ of the uuid. Perhaps we should do
that?

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation



--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: UBIFS updates for 2.6.27, Artem Bityutskiy, (Sun Aug 31, 7:32 am)
UBIFS updates for 2.6.27, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: fix zero-length truncations, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: always read hashed-key nodes under TNC mutex, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: allow for racing between GC and TNC, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: do not update min_idx_lebs in stafs, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: push empty flash hack down, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: remove incorrect index space check, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: improve statfs reporting, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: fix assertion, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: add forgotten gc_idx_lebs component, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: introduce LEB overhead, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: improve statfs reporting even more, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: fill f_fsid, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Mon Sep 1, 2:43 am)
Re: [PATCH] UBIFS: fill f_fsid, Artem Bityutskiy, (Mon Sep 1, 4:16 am)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Mon Sep 1, 4:28 am)
Re: [PATCH] UBIFS: fill f_fsid, Artem Bityutskiy, (Mon Sep 1, 4:43 am)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Mon Sep 1, 4:50 am)
Re: [PATCH] UBIFS: fill f_fsid, Artem Bityutskiy, (Mon Sep 1, 4:56 am)
Re: [PATCH] UBIFS: fill f_fsid, Christoph Hellwig, (Mon Sep 1, 8:01 am)
Re: [PATCH] UBIFS: fill f_fsid, Artem Bityutskiy, (Tue Sep 2, 12:03 am)
Re: [PATCH] UBIFS: fill f_fsid, Andreas Dilger, (Tue Sep 2, 10:09 am)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Tue Sep 2, 10:29 am)
Re: [PATCH] UBIFS: fill f_fsid, Andreas Dilger, (Tue Sep 2, 12:13 pm)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Tue Sep 2, 12:32 pm)
Re: [PATCH] UBIFS: fill f_fsid, Christoph Hellwig, (Tue Sep 2, 2:02 pm)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Tue Sep 2, 2:26 pm)
Re: [PATCH] UBIFS: fill f_fsid, Christoph Hellwig, (Tue Sep 2, 2:48 pm)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Tue Sep 2, 3:12 pm)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Tue Sep 2, 3:32 pm)
Re: [PATCH] UBIFS: fill f_fsid, Artem Bityutskiy, (Tue Sep 2, 11:20 pm)
Re: [PATCH] UBIFS: fill f_fsid, Artem Bityutskiy, (Wed Sep 3, 2:44 am)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Wed Sep 3, 3:14 am)