Re: [RFC][PATCH] Remove cgroup member from struct page

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...>
Cc: <balbir@...>, Andrew Morton <akpm@...>, <hugh@...>, <menage@...>, <xemul@...>, <linux-kernel@...>, <linux-mm@...>
Date: Monday, September 1, 2008 - 2:56 am

On Monday 01 September 2008 10:01, KAMEZAWA Hiroyuki wrote:

I think it would be nice to reduce the impact when it is not configured
anyway. Normally I would not mind so much, but this is something that
many distros will want to enable but fewer users will make use of it.

I think it is always a very good idea to try to reduce struct page size.
When looking at the performance impact though, just be careful with the
alignment of struct page... I actually think it is going to be a
performance win in many cases to make struct page 64 bytes.



If you do that, it might even be an idea to allocate flat arrays with
bootmem. It would just be slightly more tricky more tricky to fit this
in with the memory model. But that's not a requirement, just an idea
for a small optimisation.

Thanks,
Nick
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Sun Aug 31, 1:47 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, Pavel Emelyanov, (Mon Sep 1, 5:03 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 1, 5:17 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Peter Zijlstra, (Mon Sep 1, 9:19 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 2, 3:35 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Pavel Emelyanov, (Mon Sep 1, 5:43 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Sun Aug 31, 10:39 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Sun Aug 31, 11:42 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Sun Aug 31, 8:01 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, Nick Piggin, (Mon Sep 1, 2:56 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 1, 3:17 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 1, 3:19 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 2, 5:24 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 2, 6:02 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 2, 5:58 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 2, 6:07 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 2, 6:12 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 2, 6:57 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 2, 8:37 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 2, 11:33 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 8, 11:28 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 8, 11:57 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 9, 12:18 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 9, 3:37 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 9, 12:55 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Nick Piggin, (Mon Sep 8, 11:58 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 9, 12:53 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Tue Sep 9, 1:12 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 9, 8:24 am)
Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., KAMEZAWA Hiroyuki, (Wed Sep 10, 9:35 pm)
Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., KAMEZAWA Hiroyuki, (Wed Sep 10, 9:56 pm)
[RFC][PATCH] Remove cgroup member from struct page (v3), Balbir Singh, (Wed Sep 17, 7:28 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page (v3), KAMEZAWA Hiroyuki, (Thu Sep 18, 12:43 am)
Re: [RFC][PATCH] Remove cgroup member from struct page (v3), KAMEZAWA Hiroyuki, (Thu Sep 18, 7:01 am)
Re: [RFC][PATCH] Remove cgroup member from struct page (v3), KAMEZAWA Hiroyuki, (Thu Sep 18, 1:15 am)
Re: [RFC][PATCH] Remove cgroup member from struct page (v3), Hirokazu Takahashi, (Thu Sep 18, 12:26 am)
Re: [RFC][PATCH] Remove cgroup member from struct page (v3), KAMEZAWA Hiroyuki, (Thu Sep 18, 12:50 am)
Re: [RFC][PATCH] Remove cgroup member from struct page (v3), Hirokazu Takahashi, (Thu Sep 18, 2:13 am)
Re: [RFC][PATCH] Remove cgroup member from struct page (v3), KAMEZAWA Hiroyuki, (Thu Sep 18, 1:00 am)
Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., KAMEZAWA Hiroyuki, (Wed Sep 10, 7:03 am)
Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., KAMEZAWA Hiroyuki, (Wed Sep 10, 7:27 am)
Re: [Approach #2] [RFC][PATCH] Remove cgroup member from str..., KAMEZAWA Hiroyuki, (Tue Sep 9, 10:35 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Tue Sep 9, 8:34 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Wed Sep 3, 3:31 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Sun Aug 31, 11:28 pm)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 1, 12:03 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 1, 2:09 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 1, 2:24 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 1, 2:25 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 1, 2:59 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, KAMEZAWA Hiroyuki, (Mon Sep 1, 1:17 am)
Re: [RFC][PATCH] Remove cgroup member from struct page, Balbir Singh, (Mon Sep 1, 2:16 am)