Re: [PATCH 1/4] autofs4 - cleanup autofs mount type usage

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Christoph Hellwig
Date: Saturday, August 9, 2008 - 5:47 am

On Thu, Aug 07, 2008 at 07:40:06PM +0800, Ian Kent wrote:

Not enough of an explanation for this patch.

It does:

 - move AUTOFS_TYPE_INDIRECT/AUTOFS_TYPE_DIRECT/AUTOFS_TYPE_OFFSET
   to include/linux/auto_fs4.h.  Obviously okay but should mentioned
   in the changelog.
 - add a new, unused AUTOFS_TYPE_ANY constant. Why?
 - add a new AUTOFS_TYPE_TRIGGER and use it instead of
   AUTOFS_TYPE_DIRECT or in one single case
   (AUTOFS_TYPE_DIRECT|AUTOFS_TYPE_OFFSET).  Definitively needs a good
   explanation.
 - replaces one use of sbi->type = 0 with AUTOFS_TYPE_INDIRECT (0x0001).
   Why?
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 1/4] autofs4 - cleanup autofs mount type usage, Christoph Hellwig, (Sat Aug 9, 5:47 am)
Re: [PATCH 4/4] autofs4 - add miscelaneous device for ioctls, Christoph Hellwig, (Sat Aug 9, 5:59 am)
Re: [PATCH 3/4] autofs4 - devicer node ioctl docoumentation., Christoph Hellwig, (Sat Aug 9, 6:00 am)
Re: [PATCH 4/4] autofs4 - add miscelaneous device for ioctls, Christoph Hellwig, (Sat Aug 9, 10:18 am)
Re: [PATCH 2/4] autofs4 - track uid and gid of last mount ..., Serge E. Hallyn, (Mon Aug 25, 11:05 am)