Home » Mailing list archives » linux-kernel » 2008 » August » 9

Re: [PATCH 08/42] introduce nr_irqs

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Eric W. Biederman
Subject: Re: [PATCH 08/42] introduce nr_irqs
Date: Friday, August 8, 2008 - 6:00 pm

Yinghai Lu <yhlu.kernel@gmail.com> writes:


This patch is ok, but this approach is fundamentally broken. 
Only 19 architectures use GENERIC_HARDIRQS

The only required interface is interrupt.h not irq.h

So you may not replace NR_IRQS with nr_irqs in anything other
then genirq code and some architecture code.

Doing so will break the build on several architectures.

Eric
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/42] dyn_array/nr_irqs/sparse_irq support v5, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 01/42] 8250: Remove NR_IRQ usage, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 02/42] x86: add after_bootmem for 32bit, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 03/42] x86: remove irq_vectors_limits, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 04/42] add dyn_array support, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 05/42] add per_cpu_dyn_array support, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 06/42] x86: alloc dyn_array all alltogether, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 07/42] x86: enable dyn_array support, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 08/42] introduce nr_irqs, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 09/42] x86: using nr_irqs, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 10/42] drivers/char to use nr_irqs, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 11/42] drivers/net to use nr_irqs, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 12/42] drivers intr remapping to use nr_irqs, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 13/42] drivers/pcmcia to use nr_irqs, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 14/42] drivers/rtc to use nr_irqs, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 15/42] drivers/scsi to use nr_irqs, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 16/42] drivers/serial to use nr_irqs, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 17/42] drivers proc to use nr_irqs, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 18/42] drivers xen events to use nr_irqs, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 19/42] make irq_timer_state to use dyn_array, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 20/42] make irq2_iommu to use dyn_array, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 21/42] make irq_desc to use dyn_array, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 22/42] irq: make irqs in kernel stat use per_cpu_dy ..., Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 23/42] x86: use dyn_array in io_apic_xx.c, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 24/42] x86: get mp_irqs from madt, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 25/42] x86: remove nr_irq_vectors, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 26/42] x86_64: use irq_desc() together with dyn_array, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 27/42] x86: add irq_cfg in io_apic_64.c, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 28/42] x86: put irq_2_pin pointer into irq_cfg, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 29/42] x86: put timer_rand_state pointer into irq_desc, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 30/42] x86: move kstat_irqs from kstat to irq_desc, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 31/42] replace loop with nr_irqs with for_each_irq_desc, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 32/42] replace loop with nr_irqs with for_each_irq_icfg, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 33/42] remove &gt;= nr_irqs checking with config_have_ ..., Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 34/42] x86_64: add irq_desc in function in paramater, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 35/42] x86: check with without_new in show_interrupts, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 36/42] x86_64: introduce irq_cfg_with_new, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 37/42] x86_64: introduce irq_desc_with_new, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 38/42] seperate irq_descX with irq_descX_free, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 39/42] x86_64: sperate irq_cfgx with irq_cfgx_free, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 40/42] x86_64: make /proc/interrupts works with dyn ..., Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 41/42] x86_64: remove one nr_irqs in show_stat, Yinghai Lu, (Fri Aug 8, 2:52 pm)
[PATCH 42/42] x86: put irq_2_iommu pointer into irq_desc, Yinghai Lu, (Fri Aug 8, 2:52 pm)
Re: [PATCH 00/42] dyn_array/nr_irqs/sparse_irq support v5, H. Peter Anvin, (Fri Aug 8, 3:01 pm)
Re: [PATCH 00/42] dyn_array/nr_irqs/sparse_irq support v5, Yinghai Lu, (Fri Aug 8, 3:14 pm)
Re: [PATCH 00/42] dyn_array/nr_irqs/sparse_irq support v5, H. Peter Anvin, (Fri Aug 8, 3:19 pm)
Re: [PATCH 00/42] dyn_array/nr_irqs/sparse_irq support v5, H. Peter Anvin, (Fri Aug 8, 3:25 pm)
Re: [PATCH 00/42] dyn_array/nr_irqs/sparse_irq support v5, Yinghai Lu, (Fri Aug 8, 3:26 pm)
Re: [PATCH 00/42] dyn_array/nr_irqs/sparse_irq support v5, Yinghai Lu, (Fri Aug 8, 3:30 pm)
Re: [PATCH 00/42] dyn_array/nr_irqs/sparse_irq support v5, H. Peter Anvin, (Fri Aug 8, 3:33 pm)
Re: [PATCH 01/42] 8250: Remove NR_IRQ usage, Eric W. Biederman, (Fri Aug 8, 3:38 pm)
Re: [PATCH 01/42] 8250: Remove NR_IRQ usage, Yinghai Lu, (Fri Aug 8, 4:07 pm)
Re: [PATCH 00/42] dyn_array/nr_irqs/sparse_irq support v5, Eric W. Biederman, (Fri Aug 8, 4:40 pm)
Re: [PATCH 00/42] dyn_array/nr_irqs/sparse_irq support v5, Yinghai Lu, (Fri Aug 8, 5:34 pm)
Re: [PATCH 08/42] introduce nr_irqs, Eric W. Biederman, (Fri Aug 8, 6:00 pm)
Re: [PATCH 08/42] introduce nr_irqs, Yinghai Lu, (Fri Aug 8, 6:38 pm)
Re: [PATCH 08/42] introduce nr_irqs, H. Peter Anvin, (Fri Aug 8, 6:59 pm)
Re: [PATCH 08/42] introduce nr_irqs, Eric W. Biederman, (Fri Aug 8, 11:07 pm)
Re: [PATCH 08/42] introduce nr_irqs, Yinghai Lu, (Sat Aug 9, 12:30 am)
Re: [PATCH 08/42] introduce nr_irqs, Yinghai Lu, (Sat Aug 9, 12:30 am)
Re: [PATCH 08/42] introduce nr_irqs, Eric W. Biederman, (Sat Aug 9, 8:46 am)
Re: [PATCH 08/42] introduce nr_irqs, Eric W. Biederman, (Sat Aug 9, 9:02 am)
Re: [PATCH 08/42] introduce nr_irqs, Yinghai Lu, (Sat Aug 9, 2:21 pm)
Re: [PATCH 08/42] introduce nr_irqs, Yinghai Lu, (Sat Aug 9, 2:37 pm)
Re: [PATCH 08/42] introduce nr_irqs, Eric W. Biederman, (Sat Aug 9, 2:38 pm)
Re: [PATCH 08/42] introduce nr_irqs, Yinghai Lu, (Sat Aug 9, 3:35 pm)