Home » Mailing list archives » linux-kernel » 2008 » August » 8

Re: [PATCH] PNP: make the resource type an unsigned long

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: H. Peter Anvin <hpa@...>
To: Rene Herman <rene.herman@...>
Cc: Bjorn Helgaas <bjorn.helgaas@...>, Linux Kernel <linux-kernel@...>, Andrew Morton <akpm@...>
Subject: Re: [PATCH] PNP: make the resource type an unsigned long
Date: Friday, August 8, 2008 - 5:55 pm

Rene Herman wrote:

-int pnp_resource_type(struct resource *res)
+unsigned long pnp_resource_type(struct resource *res)
  {
  	return res->flags & (IORESOURCE_IO  | IORESOURCE_MEM |
  			     IORESOURCE_IRQ | IORESOURCE_DMA);
  }

Seems a bit pointless ... either one of those flags is >= 32 bits, in 
which case we need u64, or it's not, in which case there is no reason to 
burden the output with bits we don't need.

	-hpa
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] PNP: make the resource type an unsigned long, Rene Herman, (Fri Aug 8, 2:39 am)
Re: [PATCH] PNP: make the resource type an unsigned long, Bjorn Helgaas, (Mon Aug 11, 5:59 pm)
Re: [PATCH] PNP: make the resource type an unsigned long, Rene Herman, (Tue Aug 12, 12:15 am)
Re: [PATCH] PNP: make the resource type an unsigned long, H. Peter Anvin, (Mon Aug 11, 6:08 pm)
Re: [PATCH] PNP: make the resource type an unsigned long, Bjorn Helgaas, (Mon Aug 11, 6:18 pm)
Re: [PATCH] PNP: make the resource type an unsigned long, H. Peter Anvin, (Fri Aug 8, 5:55 pm)
Re: [PATCH] PNP: make the resource type an unsigned long, Rene Herman, (Sat Aug 9, 1:21 am)
Re: [PATCH] PNP: make the resource type an unsigned long, H. Peter Anvin, (Sat Aug 9, 1:25 am)
Re: [PATCH] PNP: make the resource type an unsigned long, Rene Herman, (Sat Aug 9, 1:32 am)