Home » Mailing list archives » linux-kernel » 2008 » August » 8

[Patch 2.6] s390 - Allow ECKD devices to be used with older controllers and emulation

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ivan Warren <ivan@...>
To: <linux-kernel@...>
Subject: [Patch 2.6] s390 - Allow ECKD devices to be used with older controllers and emulation
Date: Friday, August 8, 2008 - 2:46 pm

Crowd,

Apologies if this is not formatted correctly, but I'm fairly new to this 
(submitting patches that is)..

**************
    s390 dasd ECKD drivers issues a Perform Subsystem Function / Prepare 
for Read SubSystem Data with a length of 16.
    However, older hardware and documentation specifies a length of 12 
leading to a possible Incorrect Length indication.
    This patch activates the SLI CCW flag in order to avoid reporting 
the Incorrect Length indication since it is possible that the DASD 
control unit may be expecting a length of 12, not 16.
        -- Ivan Warren (ivan@vmfacility.fr)

diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
index 773b3fe..c4e3935 100644
--- a/drivers/s390/block/dasd_eckd.c
+++ b/drivers/s390/block/dasd_eckd.c
@@ -810,6 +810,7 @@ static int dasd_eckd_read_features(struct 
dasd_device *device)
        ccw->cmd_code = DASD_ECKD_CCW_PSF;
        ccw->count = sizeof(struct dasd_psf_prssd_data);
        ccw->flags |= CCW_FLAG_CC;
+       ccw->flags |= CCW_FLAG_SLI;
        ccw->cda = (__u32)(addr_t) prssdp;

        /* Read Subsystem Data - feature codes */
**************

--Ivan
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[Patch 2.6] s390 - Allow ECKD devices to be used with older ..., Ivan Warren, (Fri Aug 8, 2:46 pm)
Fwd: [Patch 2.6] s390 - Allow ECKD devices to be used with o..., Frans Pop, (Wed Aug 13, 7:07 pm)
Re: Fwd: [Patch 2.6] s390 - Allow ECKD devices to be used wi..., Martin Schwidefsky, (Thu Aug 14, 11:07 am)
[PATCH] S390 : Set SLI on PSF/PRSSD on Dasd ECKD initialisat..., Ivan Warren, (Thu Aug 14, 2:26 pm)
Re: [PATCH] S390 : Set SLI on PSF/PRSSD on Dasd ECKD initial..., Stefan Weinhuber, (Fri Aug 15, 10:15 am)
Re: [PATCH] S390 : Set SLI on PSF/PRSSD on Dasd ECKD initial..., Ivan Warren, (Mon Aug 18, 1:08 pm)
Re: [PATCH] S390 : Set SLI on PSF/PRSSD on Dasd ECKD initial..., Frans Pop, (Mon Aug 18, 1:56 pm)
Re: [PATCH] S390 : Set SLI on PSF/PRSSD on Dasd ECKD initial..., Stefan Weinhuber, (Thu Aug 21, 12:32 pm)