login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
August
»
7
Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG_SMP is set
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Pavel Machek
Subject:
Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG_SMP is set
Date: Thursday, August 7, 2008 - 1:12 am
Hi!
quoted text
> > > arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used > > > > > > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> > > > Cc: Glauber Costa <gcosta@redhat.com> > > > Cc: Pavel Machek <pavel@suse.cz> > > > Cc: Ingo Molnar <mingo@elte.hu> > > > --- > > > arch/x86/kernel/acpi/sleep.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c > > > index fa2161d..9103cb6 100644 > > > --- a/arch/x86/kernel/acpi/sleep.c > > > +++ b/arch/x86/kernel/acpi/sleep.c > > > @@ -20,7 +20,7 @@ unsigned long acpi_realmode_flags; > > > /* address in low memory of the wakeup routine. */ > > > static unsigned long acpi_realmode; > > > > > > -#ifdef CONFIG_64BIT > > > +#ifdef CONFIG_SMP > > > static char temp_stack[10240]; > > > #endif > > > > > > > Now it still generates the warning, but on i386 with CONFIG_SMP set, > > instead of x86_64 without CONFIG_SMP. We only need temp_stack, when both > > CONFIG_64BIT and CONFIG_SMP are activated. > > Yes. Thanks for looking at the patch! > > --- > From c6e673acf02e8bf04866cadf17c1cb1fa4d852ea Mon Sep 17 00:00:00 2001 > From: Marcin Slusarz <marcin.slusarz@gmail.com> > Subject: [PATCH] x86, acpi: temp_stack is used only when CONFIG_64BIT && CONFIG_SMP is set > > arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used > > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> > Cc: Glauber Costa <gcosta@redhat.com>
Acked-by: Pavel Machek <pavel@suse.cz> Ingo, can you merge this one? Pavel -- (english)
http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] x86, acpi: temp_stack is used only when CONFIG_SMP ...
, Marcin Slusarz
, (Sun Aug 3, 9:52 am)
Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG ...
, Sven Wegener
, (Sun Aug 3, 10:07 am)
Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG ...
, Marcin Slusarz
, (Sun Aug 3, 10:25 am)
Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG ...
, Pavel Machek
, (Thu Aug 7, 1:12 am)
Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG ...
, Marcin Slusarz
, (Fri Aug 15, 5:12 am)
Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG ...
, Ingo Molnar
, (Fri Aug 15, 7:41 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Stefan Richter
Re: sata & scsi suggestion for make menuconfig
Rafael J. Wysocki
[Bug #11409] build issue #564 for v2.6.27-rc4 : undefined reference to `NS8390p_in...
Greg Kroah-Hartman
[PATCH 20/36] Driver core: Call device_pm_add() after bus_add_device() in device_a...
Marcin Slusarz
Re: [PATCH] ufs: [bl]e*_add_cpu conversion
Andrew Morton
2.6.23-rc6-mm1
git
:
Junio C Hamano
Re: git-svnimport
Anuj Gakhar
Git Architecture Question
Johannes Schindelin
Re: [PATCH] Fix approxidate("never") to always return 0
A Large Angry SCM
Re: [RFC] origin link for cherry-pick and revert
Gabriel
[PATCH] When a remote is added but not fetched, tell the user.
linux-netdev
:
Gerrit Renker
v2 [PATCH 1/4] dccp: Limit feature negotiation to connection setup phase
Daniel Lezcano
getsockopt(TCP_DEFER_ACCEPT) value change
David Miller
Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
Ingo Molnar
Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference
Gerrit Renker
[PATCH 37/37] dccp: Debugging functions for feature negotiation
git-commits-head
:
Linux Kernel Mailing List
ath9k_htc: Allocate URBs properly
Linux Kernel Mailing List
[ARM] dma: use new dmabounce_sync_for_xxx() for dma_sync_single_xxx()
Linux Kernel Mailing List
MIPS: Cavium: Remove unused watchdog code.
Linux Kernel Mailing List
V4L/DVB (8976): af9015: Add USB ID for AVerMedia A309
Linux Kernel Mailing List
ARM: 5670/1: bcmring: add default configuration for bcmring arch
openbsd-misc
:
Christophe Rioux
Implementation example of snmp
Jason Dixon
Re: any web management gui for pf ?
Nick Holland
Re: booting openbsd on eee without cd-rom
Bryan Irvine
Re: OpenBSD 4.7 Released, May 19 2010
Marco Peereboom
Re: Singularity OS
Colocation donated by:
Syndicate