[PATCH] ftrace: printk formatting infrastructure fix 2

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Johannes Weiner
Date: Thursday, August 7, 2008 - 6:40 am

Hi,

akpm@linux-foundation.org writes:


---
The attribute on the function definition breaks compilation.  Instead of
removing it, we could use a declaration and add the attribute there, but
then, when someone adds new ftrace_printk()s, she will probably compile
with CONFIG_TRACING and the callsite is garuanteed to be verified during
development.

Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
---
 include/linux/ftrace.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/include/linux/ftrace.h
+++ b/include/linux/ftrace.h
@@ -165,7 +165,7 @@ __ftrace_printk(unsigned long ip, const 
 static inline void
 ftrace_special(unsigned long arg1, unsigned long arg2, unsigned long arg3) { }
 static inline int
-ftrace_printk(const char *fmt, ...) __attribute__ ((format (printf, 1, 0)))
+ftrace_printk(const char *fmt, ...)
 {
 	return 0;
 }
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] ftrace: printk formatting infrastructure fix 2, Johannes Weiner, (Thu Aug 7, 6:40 am)
Re: [PATCH] ftrace: printk formatting infrastructure fix 2, Johannes Weiner, (Fri Aug 8, 3:47 am)