Re: [PATCH 00/33] dyn_array and nr_irqs support v4

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Eric W. Biederman
Date: Wednesday, August 6, 2008 - 10:37 am

Yinghai Lu <yhlu.kernel@gmail.com> writes:


It looks like you might possibly be iterating to something usable.
Breaking architectures is not acceptable however.

My suggestion for a non-breaking path:
- Kill NR_IRQS in then generic code.
  With Alan's serial patch and my kstat patch it looks like we have
  the worst of that.

- Introduce get_irq_desc and the functions or function modifications
  that pass a struct irq_desc * into the genirq code.

  Although I absolutely hate the name get_irq_desc as it implies we are
  reference counting something and need a corresponding put_irq_desc.
  Since the lifetime rules don't require that.  Please just call the
  function irq_desc().

- Update arch/x86 to do everything interesting with irq_desc pointers.

- Start dynamically allocating irq_desc and irq_cfg.

Eric

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/33] dyn_array and nr_irqs support v4, Yinghai Lu, (Wed Aug 6, 1:38 am)
[PATCH 01/33] x86: add after_bootmem for 32bit, Yinghai Lu, (Wed Aug 6, 1:38 am)
[PATCH 02/33] x86: remove irq_vectors_limits, Yinghai Lu, (Wed Aug 6, 1:38 am)
Re: [PATCH 00/33] dyn_array and nr_irqs support v4, Eric W. Biederman, (Wed Aug 6, 10:37 am)
Re: [PATCH 00/33] dyn_array and nr_irqs support v4, Yinghai Lu, (Wed Aug 6, 11:29 am)
Re: [PATCH 00/33] dyn_array and nr_irqs support v4, Yinghai Lu, (Wed Aug 6, 11:50 am)
Re: [PATCH 00/33] dyn_array and nr_irqs support v4, Eric W. Biederman, (Wed Aug 6, 1:32 pm)
Re: [PATCH 00/33] dyn_array and nr_irqs support v4, Eric W. Biederman, (Wed Aug 6, 1:35 pm)
Re: [PATCH 00/33] dyn_array and nr_irqs support v4, Yinghai Lu, (Wed Aug 6, 1:52 pm)
Re: [PATCH 00/33] dyn_array and nr_irqs support v4, Yinghai Lu, (Wed Aug 6, 1:57 pm)
Re: [PATCH 00/33] dyn_array and nr_irqs support v4, Eric W. Biederman, (Wed Aug 6, 6:02 pm)
Re: [PATCH 00/33] dyn_array and nr_irqs support v4, Yinghai Lu, (Thu Aug 7, 3:51 am)
Re: [PATCH 00/33] dyn_array and nr_irqs support v4, H. Peter Anvin, (Thu Aug 7, 11:12 am)