Re: [PATCH 4/7] bio-cgroup: Split the cgroup memory subsystem into two parts

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <kamezawa.hiroyu@...>
Cc: <ryov@...>, <xen-devel@...>, <containers@...>, <linux-kernel@...>, <virtualization@...>, <dm-devel@...>, <agk@...>
Date: Wednesday, August 6, 2008 - 7:43 am

Hi,


I don't think it will cause significant performance loss, because
the link between a page and a page_cgroup has already existed, which
the memory resource controller prepared. Bio_cgroup uses this as it is,
and does nothing about this.

And the link between page_cgroup and bio_cgroup isn't protected
by any additional spin-locks, since the associated bio_cgroup is
guaranteed to exist as long as the bio_cgroup owns pages.

I've just noticed that most of overhead comes from the spin-locks
when reclaiming the pages inside mem_cgroups and the spin-locks to
protect the links between pages and page_cgroups.
The latter overhead comes from the policy your team has chosen
that page_cgroup structures are allocated on demand. I still feel
this approach doesn't make any sense because linux kernel tries to
make use of most of the pages as far as it can, so most of them
have to be assigned its related page_cgroup. It would make us happy
if page_cgroups are allocated at the booting time.


I don't think there are any diffrences between a poiter and ID.
I think this ID is just a encoded version of the pointer.



--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Too many I/O controller patches, Dave Hansen, (Mon Aug 4, 1:20 pm)
Re: RFC: I/O bandwidth controller, Hirokazu Takahashi, (Fri Aug 8, 2:21 am)
Re: RFC: I/O bandwidth controller, Hirokazu Takahashi, (Fri Aug 8, 10:31 am)
Re: RFC: I/O bandwidth controller, Ryo Tsuruta, (Fri Aug 8, 3:20 am)
Re: RFC: I/O bandwidth controller, Fernando Luis , (Fri Aug 8, 4:10 am)
Re: RFC: I/O bandwidth controller, Ryo Tsuruta, (Fri Aug 8, 6:05 am)
Re: RFC: I/O bandwidth controller (was Re: Too many I/O cont..., David Collier-Brown, (Mon Aug 11, 12:35 pm)
Re: RFC: I/O bandwidth controller, Hirokazu Takahashi, (Thu Aug 7, 4:30 am)
Re: RFC: I/O bandwidth controller, Hirokazu Takahashi, (Fri Aug 8, 7:39 am)
Re: RFC: I/O bandwidth controller, Fernando Luis , (Tue Aug 12, 1:35 am)
Re: RFC: I/O bandwidth controller, Ryo Tsuruta, (Wed Aug 6, 2:18 am)
Re: RFC: I/O bandwidth controller, Fernando Luis , (Wed Aug 6, 2:41 am)
Re: RFC: I/O bandwidth controller, Dave Hansen, (Wed Aug 6, 11:48 am)
Re: RFC: I/O bandwidth controller, Fernando Luis , (Thu Aug 7, 12:38 am)
Re: Too many I/O controller patches, Balbir Singh, (Mon Aug 4, 2:34 pm)
Re: Too many I/O controller patches, Andrea Righi, (Mon Aug 4, 4:42 pm)
Re: Too many I/O controller patches, Andrea Righi, (Mon Aug 4, 2:22 pm)
RE: Too many I/O controller patches, Satoshi UCHIDA, (Mon Aug 4, 10:50 pm)
Re: Too many I/O controller patches, Hirokazu Takahashi, (Tue Aug 5, 8:01 am)
Re: Too many I/O controller patches, Andrea Righi, (Tue Aug 5, 5:28 am)
Re: Too many I/O controller patches, Dave Hansen, (Tue Aug 5, 12:20 pm)
Re: Too many I/O controller patches, KAMEZAWA Hiroyuki, (Tue Aug 5, 10:44 pm)
Re: Too many I/O controller patches, Hirokazu Takahashi, (Wed Aug 6, 2:48 am)
Re: Too many I/O controller patches, Balbir Singh, (Tue Aug 5, 11:30 pm)
Re: Too many I/O controller patches, Ryo Tsuruta, (Tue Aug 5, 9:17 am)
Re: Too many I/O controller patches, Dave Hansen, (Mon Aug 4, 3:02 pm)
Re: Too many I/O controller patches, Andrea Righi, (Mon Aug 4, 4:44 pm)
Re: Too many I/O controller patches, Hirokazu Takahashi, (Tue Aug 5, 2:16 am)
Re: Too many I/O controller patches, Andrea Righi, (Tue Aug 5, 5:31 am)
Re: Too many I/O controller patches, Hirokazu Takahashi, (Tue Aug 5, 6:01 am)
Re: Too many I/O controller patches, Paul Menage, (Tue Aug 5, 1:55 am)
Re: Too many I/O controller patches, Dave Hansen, (Tue Aug 5, 12:25 pm)
Re: Too many I/O controller patches, Andrea Righi, (Tue Aug 5, 5:27 am)
Re: Too many I/O controller patches, Balbir Singh, (Tue Aug 5, 2:03 am)
Re: Too many I/O controller patches, Dave Hansen, (Mon Aug 4, 4:50 pm)
Re: Too many I/O controller patches, Hirokazu Takahashi, (Tue Aug 5, 2:28 am)
[PATCH 1/7] dm-ioband: Patch of device-mapper driver, Ryo Tsuruta, (Mon Aug 4, 4:52 am)
[PATCH 3/7] bio-cgroup: Introduction, Ryo Tsuruta, (Mon Aug 4, 4:57 am)
Re: [PATCH 4/7] bio-cgroup: Split the cgroup memory subsyste..., Hirokazu Takahashi, (Wed Aug 6, 7:43 am)
Re: [PATCH 4/7] bio-cgroup: Split the cgroup memory subsyste..., Hirokazu Takahashi, (Thu Aug 7, 3:25 am)
Re: [PATCH 4/7] bio-cgroup: Split the cgroup memory subsyste..., Hirokazu Takahashi, (Thu Aug 7, 4:45 am)
Re: [PATCH 4/7] bio-cgroup: Split the cgroup memory subsyste..., Hirokazu Takahashi, (Tue Aug 5, 6:35 am)
[PATCH 5/7] bio-cgroup: Remove a lot of ifdefs, Ryo Tsuruta, (Mon Aug 4, 4:59 am)
[PATCH 6/7] bio-cgroup: Implement the bio-cgroup, Ryo Tsuruta, (Mon Aug 4, 5:00 am)
Re: [PATCH 6/7] bio-cgroup: Implement the bio-cgroup, Takuya Yoshikawa, (Fri Aug 8, 3:10 am)
Re: [PATCH 6/7] bio-cgroup: Implement the bio-cgroup, Ryo Tsuruta, (Fri Aug 8, 4:30 am)
Re: [PATCH 6/7] bio-cgroup: Implement the bio-cgroup, Takuya Yoshikawa, (Fri Aug 8, 5:42 am)
Re: [PATCH 6/7] bio-cgroup: Implement the bio-cgroup, Ryo Tsuruta, (Fri Aug 8, 7:41 am)