Re: [PATCH 2.6.27-rc1-git5 2/26] mdb: correct kprobes int3 trap

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Stefan Richter
Date: Wednesday, August 6, 2008 - 1:15 am

jmerkey@wolfmountaingroup.com wrote on 2008-08-05:

I guess you got complaints from scripts/checkpatch.pl for at least 3/4 
of all lines by now.  Some or many of the complaints will probably look 
silly.  Have a look at Documentation/CodingStyle then because it gives 
context for many of the complaints.  It also gives some rules of thumb 
for things which checkpatch.pl cannot check, e.g. legibility of global 
names.

 From what I saw, there are _many_ whitespace "deviations" in your code 
(which perhaps scripts/Lindent can help to adjust), upper case vs. lower 
case in names, and occasional functions which are deeper nested than 
probably necessary, as already mentioned.
-- 
Stefan Richter
-=====-==--- =--- --==-
http://arcgraph.de/sr/
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 2.6.27-rc1-git5 2/26] mdb: correct kprobes int3 ..., Stefan Richter, (Wed Aug 6, 1:15 am)
Re: [PATCH 2.6.27-rc1-git5 2/26] mdb: correct kprobes int3 ..., Ananth N Mavinakayan ..., (Wed Aug 6, 1:40 am)