Home » Mailing list archives » linux-kernel » 2008 » August » 4

[patch 03/33] SCSI: megaraid_mbox: fix Dell CERC firmware problem

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Greg KH
Subject: [patch 03/33] SCSI: megaraid_mbox: fix Dell CERC firmware problem
Date: Monday, August 4, 2008 - 1:14 pm

2.6.25-stable review patch.  If anyone has any objections, please let us
know.

------------------

From: Hannes Reinecke <hare@suse.de>

commit 69cd39e94669e2994277a29249b6ef93b088ddbb upstream

Newer Dell CERC firmware (>= 6.62) implement a random deletion handling
compatible with the legacy megaraid driver.  The legacy handling shifted
the target ID by 0x80 only for I/O commands (READ/WRITE/etc), whereas
megaraid_mbox shifts the target ID always if random deletion is supported.
The resulted in megaraid_mbox sending an INQUIRY to the wrong channel, and
not finding any devices, obviously.

So we disable the random deletion support if the offending firmware is
found.

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=6695

Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Bo Yang <Bo.Yang@lsi.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/scsi/megaraid/megaraid_mbox.c |   17 +++++++++++++++++
 drivers/scsi/megaraid/megaraid_mbox.h |    1 +
 2 files changed, 18 insertions(+)

--- a/drivers/scsi/megaraid/megaraid_mbox.c
+++ b/drivers/scsi/megaraid/megaraid_mbox.c
@@ -3168,6 +3168,23 @@ megaraid_mbox_support_random_del(adapter
 	uint8_t		raw_mbox[sizeof(mbox_t)];
 	int		rval;
 
+	/*
+	 * Newer firmware on Dell CERC expect a different
+	 * random deletion handling, so disable it.
+	 */
+	if (adapter->pdev->vendor == PCI_VENDOR_ID_AMI &&
+	    adapter->pdev->device == PCI_DEVICE_ID_AMI_MEGARAID3 &&
+	    adapter->pdev->subsystem_vendor == PCI_VENDOR_ID_DELL &&
+	    adapter->pdev->subsystem_device == PCI_SUBSYS_ID_CERC_ATA100_4CH &&
+	    (adapter->fw_version[0] > '6' ||
+	     (adapter->fw_version[0] == '6' &&
+	      adapter->fw_version[2] > '6') ||
+	     (adapter->fw_version[0] == '6'
+	      && adapter->fw_version[2] == '6'
+	      && adapter->fw_version[3] > '1'))) {
+		con_log(CL_DLEVEL1, ("megaraid: disable random deletion\n"));
+		return 0;
+	}
 
 	mbox = (mbox_t *)raw_mbox;
 
--- a/drivers/scsi/megaraid/megaraid_mbox.h
+++ b/drivers/scsi/megaraid/megaraid_mbox.h
@@ -88,6 +88,7 @@
 #define PCI_SUBSYS_ID_PERC3_QC				0x0471
 #define PCI_SUBSYS_ID_PERC3_DC				0x0493
 #define PCI_SUBSYS_ID_PERC3_SC				0x0475
+#define PCI_SUBSYS_ID_CERC_ATA100_4CH			0x0511
 
 
 #define MBOX_MAX_SCSI_CMDS	128	// number of cmds reserved for kernel

-- 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 00/33] 2.6.25-stable review cycle, Greg KH, (Mon Aug 4, 1:13 pm)
[patch 01/33] romfs_readpage: dont report errors for pages ..., Greg KH, (Mon Aug 4, 1:14 pm)
[patch 02/33] x86: ioremap of 64-bit resource on 32-bit ke ..., Greg KH, (Mon Aug 4, 1:14 pm)
[patch 03/33] SCSI: megaraid_mbox: fix Dell CERC firmware ..., Greg KH, (Mon Aug 4, 1:14 pm)
[patch 04/33] return to old errno choice in mkdir() et.al., Greg KH, (Mon Aug 4, 1:14 pm)
[patch 05/33] POWERPC: PS3: Add time include to lpm, Greg KH, (Mon Aug 4, 1:14 pm)
[patch 06/33] NFS: Ensure we zap only the access and acl c ..., Greg KH, (Mon Aug 4, 1:14 pm)
[patch 07/33] jbd: fix the way the b_modified flag is cleared, Greg KH, (Mon Aug 4, 1:14 pm)
[patch 08/33] jbd: fix race between free buffer and commit ..., Greg KH, (Mon Aug 4, 1:15 pm)
[patch 09/33] jbd: fix possible journal overflow issues, Greg KH, (Mon Aug 4, 1:15 pm)
[patch 10/33] Input: i8042 - retry failed CTR writes when ..., Greg KH, (Mon Aug 4, 1:15 pm)
[patch 11/33] Input: i8042 - add Intel D845PESV to nopnp list, Greg KH, (Mon Aug 4, 1:15 pm)
[patch 12/33] Input: i8042 - add Gericom Bellagio to nomux ..., Greg KH, (Mon Aug 4, 1:15 pm)
[patch 13/33] Input: i8042 - add Fujitsu-Siemens Amilo Pro ..., Greg KH, (Mon Aug 4, 1:15 pm)
[patch 14/33] Input: i8042 - add Fujitsu-Siemens Amilo Pro ..., Greg KH, (Mon Aug 4, 1:15 pm)
[patch 15/33] Input: i8042 - add Acer Aspire 1360 to nomux ..., Greg KH, (Mon Aug 4, 1:15 pm)
[patch 16/33] FAT_VALID_MEDIA(): remove pointless test, Greg KH, (Mon Aug 4, 1:15 pm)
[patch 17/33] fat: detect media without partition table co ..., Greg KH, (Mon Aug 4, 1:15 pm)
[patch 18/33] Bluetooth: Signal user-space for HIDP and BN ..., Greg KH, (Mon Aug 4, 1:15 pm)
[patch 19/33] bay: exit if notify handler cannot be installed, Greg KH, (Mon Aug 4, 1:15 pm)
[patch 20/33] ath5k: Use software encryption for now, Greg KH, (Mon Aug 4, 1:15 pm)
[patch 21/33] Add compat handler for PTRACE_GETSIGINFO, Greg KH, (Mon Aug 4, 1:16 pm)
[patch 22/33] ACPI: Reject below-freezing temperatures as ..., Greg KH, (Mon Aug 4, 1:16 pm)
[patch 23/33] ACPI: update thermal temperature, Greg KH, (Mon Aug 4, 1:16 pm)
[patch 24/33] Input: appletouch - implement reset-resume logic, Greg KH, (Mon Aug 4, 1:16 pm)
[patch 25/33] USB: EHCI: fix remote-wakeup regression, Greg KH, (Mon Aug 4, 1:16 pm)
[patch 26/33] pci: VT3336 cant do MSI either, Greg KH, (Mon Aug 4, 1:16 pm)
[patch 27/33] ALSA: ac97 - Fix ASUS A9T laptop output, Greg KH, (Mon Aug 4, 1:16 pm)
[patch 28/33] ALSA: Add more fallbacks to OSS PHONEOUT mix ..., Greg KH, (Mon Aug 4, 1:16 pm)
[patch 29/33] ALSA: emu10k1 - Fix inverted Analog/Digital ..., Greg KH, (Mon Aug 4, 1:16 pm)
[patch 30/33] ALSA: Fix Oops with usb-audio reconnection, Greg KH, (Mon Aug 4, 1:16 pm)
[patch 31/33] ALSA: hda - Add missing Thinkpad Z60m support, Greg KH, (Mon Aug 4, 1:16 pm)
[patch 32/33] ALSA: hda - Fix wrong volumes in AD1988 auto ..., Greg KH, (Mon Aug 4, 1:16 pm)
[patch 33/33] vfs: fix lookup on deleted directory, Greg KH, (Mon Aug 4, 1:16 pm)