Re: [PATCH] workaround minor lockdep bug triggered by mm_take_all_locks

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Roland Dreier <rdreier@...>

Cc: Andrea Arcangeli <andrea@...>, Dave Jones <davej@...>, Linus Torvalds <torvalds@...>, David Miller <davem@...>, <jeremy@...>, <hugh@...>, <mingo@...>, <akpm@...>, <linux-kernel@...>

Subject: Re: [PATCH] workaround minor lockdep bug triggered by mm_take_all_locks

Date: Monday, August 4, 2008 - 3:05 pm

On Mon, 2008-08-04 at 11:56 -0700, Roland Dreier wrote:
quoted text> > NAK, come-on, you didn't even bother to look at the available
>  > annotations..
> 
> Agree that this trylock-in-a-loop is a horrible hack that should never
> be merged.
> 
> However I wonder what you think the right way to annotate the
> potentially unbounded number of locks taken in mm_take_all_locks() is?

Good question, one which I don't currently have an answer for - see my
other mail why getting rid of the MAX_LOCK_DEPTH limitation is hard.

I'll give it another serious go tomorrow (if nothing else preempts me).

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Peter Zijlstra, (Mon Aug 4, 9:03 am)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Peter Zijlstra, (Thu Aug 7, 7:25 am)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Jeremy Fitzhardinge, (Mon Aug 4, 2:06 pm)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Peter Zijlstra, (Mon Aug 4, 2:54 pm)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Jeremy Fitzhardinge, (Mon Aug 4, 3:26 pm)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Linus Torvalds, (Mon Aug 4, 3:31 pm)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Steven Rostedt, (Wed Oct 8, 11:27 am)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Nick Piggin, (Wed Oct 8, 11:52 am)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Steven Rostedt, (Wed Oct 8, 1:18 pm)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Linus Torvalds, (Wed Oct 8, 11:43 am)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Steven Rostedt, (Wed Oct 8, 12:03 pm)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Linus Torvalds, (Wed Oct 8, 12:19 pm)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Steven Rostedt, (Wed Oct 8, 12:53 pm)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Jeremy Fitzhardinge, (Mon Aug 4, 4:16 pm)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Peter Zijlstra, (Mon Aug 4, 3:39 pm)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Roland Dreier, (Mon Aug 4, 10:07 am)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Peter Zijlstra, (Mon Aug 4, 10:19 am)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Roland Dreier, (Mon Aug 4, 10:26 am)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Peter Zijlstra, (Mon Aug 4, 10:32 am)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Dave Jones, (Mon Aug 4, 10:53 am)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Peter Zijlstra, (Mon Aug 4, 10:56 am)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Andrea Arcangeli, (Mon Aug 4, 12:26 pm)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Peter Zijlstra, (Mon Aug 4, 12:38 pm)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), David Miller, (Mon Aug 4, 5:32 pm)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Andrea Arcangeli, (Mon Aug 4, 1:27 pm)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Peter Zijlstra, (Mon Aug 4, 2:48 pm)

Re: [RFC][PATCH 7/7] lockdep: spin_lock_nest_lock(), Andrea Arcangeli, (Mon Aug 4, 1:46 pm)

[PATCH] workaround minor lockdep bug triggered by mm_take_al..., Andrea Arcangeli, (Mon Aug 4, 1:57 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Peter Zijlstra, (Mon Aug 4, 2:48 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Andrea Arcangeli, (Mon Aug 4, 4:15 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Peter Zijlstra, (Mon Aug 4, 4:37 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Andrea Arcangeli, (Mon Aug 4, 5:09 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Roland Dreier, (Mon Aug 4, 10:00 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Andrea Arcangeli, (Mon Aug 4, 10:18 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Roland Dreier, (Tue Aug 5, 8:02 am)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Andrea Arcangeli, (Tue Aug 5, 8:20 am)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., David Miller, (Mon Aug 4, 5:57 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Arjan van de Ven, (Mon Aug 4, 5:27 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Andrea Arcangeli, (Mon Aug 4, 5:54 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Pekka Enberg, (Mon Aug 4, 5:14 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Andrea Arcangeli, (Mon Aug 4, 5:30 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Arjan van de Ven, (Mon Aug 4, 5:42 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Andrea Arcangeli, (Mon Aug 4, 6:30 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Arjan van de Ven, (Mon Aug 4, 7:38 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Andrea Arcangeli, (Mon Aug 4, 8:47 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Andrew Morton, (Mon Aug 4, 5:41 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Andrea Arcangeli, (Mon Aug 4, 6:12 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Roland Dreier, (Mon Aug 4, 2:56 pm)

Re: [PATCH] workaround minor lockdep bug triggered by mm_tak..., Peter Zijlstra, (Mon Aug 4, 3:05 pm)

Navigation

Popular discussions


linux-kernel:
Dave Hansen	[RFC][PATCH 0/4] kernel-based checkpoint restart
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Bart Van Assche	Integration of SCST in the mainstream Linux kernel
Eric Paris	[RFC 0/5] [TALPA] Intro to a linux interface for on access scanning
git:

linux-netdev:
David Miller	Re: [GIT]: Networking
Natalie Protasevich	[BUG] New Kernel Bugs
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc:

Colocation donated by:

Online users

Syndicate