Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API.

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Herbert Xu <herbert@...>

To: David Woodhouse <dwmw2@...>

Cc: Austin Zhang <austin_zhang@...>, <davem@...>, <linux-kernel@...>, <linux-crypto@...>

Subject: Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API.

Date: Monday, August 4, 2008 - 10:17 am

On Mon, Aug 04, 2008 at 03:13:34PM +0100, David Woodhouse wrote:
quoted text>
> > +static int __init crc32c_intel_mod_init(void)
> > +{
> > +	return crypto_register_alg(&alg);
> > +}
> > +
> 
> Am I missing something here, or are you registering the crypto algorithm
> _unconditionally_ and then just causing init requests for it to fail on
> older hardware?  Wouldn't it be better to register the driver _only_
> when the hardware is capable? Or at least "if at least one cpu is
> capable".

Yes I think this is a show-stopper :)

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] Using Intel CRC32 instruction to accelerate CRC32c a..., Austin Zhang, (Mon Aug 4, 5:35 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Randy Dunlap, (Mon Aug 4, 1:27 pm)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Austin Zhang, (Tue Aug 5, 6:12 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 10:19 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Austin Zhang, (Tue Aug 5, 5:59 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Tue Aug 5, 6:44 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 10:18 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., David Woodhouse, (Mon Aug 4, 10:13 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Austin Zhang, (Tue Aug 5, 5:51 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 10:17 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., David Woodhouse, (Mon Aug 4, 6:12 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Austin Zhang, (Mon Aug 4, 6:35 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., David Woodhouse, (Mon Aug 4, 6:45 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Chris Mason, (Mon Aug 4, 9:45 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 11:42 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Benoit Boissinot, (Mon Aug 4, 2:02 pm)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 10:08 pm)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Chris Mason, (Mon Aug 4, 12:14 pm)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 12:45 pm)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Arjan van de Ven, (Mon Aug 4, 1:06 pm)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 1:10 pm)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 1:13 pm)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Helge Hafting, (Tue Aug 5, 7:10 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Tue Aug 5, 10:04 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 10:04 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Arjan van de Ven, (Mon Aug 4, 10:20 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 11:12 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., David Woodhouse, (Mon Aug 4, 10:49 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 10:54 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Austin Zhang, (Mon Aug 4, 6:58 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., David Woodhouse, (Mon Aug 4, 7:25 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Sebastian Siewior, (Mon Aug 4, 6:25 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 6:48 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., David Woodhouse, (Mon Aug 4, 6:27 am)

Navigation

Popular discussions


linux-kernel:
Greg KH	[GIT PATCH] driver core patches against 2.6.24
James Bottomley	Re: Integration of SCST in the mainstream Linux kernel
Stephen Rothwell	Re: Announce: Linux-next (Or Andrew's dream :-))
Arjan van de Ven	Re: [malware-list] [RFC 0/5] [TALPA] Intro to a linux interfaceforon access scanning
linux-netdev:
Patrick McHardy	Re: [GIT]: Networking
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Eric W. Biederman	Re: namespace support requires network modules to say "GPL"
git:

openbsd-misc:

Colocation donated by: