Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API. | KernelTrap

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API.

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Sebastian Siewior <linux-crypto@...>

To: David Woodhouse <dwmw2@...>

Cc: Austin Zhang <austin_zhang@...>, <herbert@...>, <davem@...>, <linux-kernel@...>, <linux-crypto@...>

Subject: Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API.

Date: Monday, August 4, 2008 - 6:25 am

* David Woodhouse | 2008-08-04 11:12:05 [+0100]:

quoted text>On Mon, 2008-08-04 at 05:35 -0400, Austin Zhang wrote:
>> +u32 __pure crc32c_intel_le_hw(u32 crc, unsigned char const *p, size_t
>> len)
>> +{
>> +       unsigned int iquotient = len / SCALE_F;
>> +       unsigned int iremainder = len % SCALE_F;
>> +#ifdef CONFIG_X86_64
>> +       u64 *ptmp = (u64 *)p;
>> +#else
>> +       u32 *ptmp = (u32 *)p;
>> +#endif
>
>You could perhaps just use 'unsigned long' here, to avoid the ifdef.
>
>And it would be nice if we could make libcrc32c use this too, rather
>than just the 'crypto' users.

I'm not sure if I remeber correctly but I thing Herbert was planning to
convert all users over to the crypto API to avoid compile time
dependency.

Sebastian
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] Using Intel CRC32 instruction to accelerate CRC32c a..., Austin Zhang, (Mon Aug 4, 5:35 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Randy Dunlap, (Mon Aug 4, 1:27 pm)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Austin Zhang, (Tue Aug 5, 6:12 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 10:19 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Austin Zhang, (Tue Aug 5, 5:59 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Tue Aug 5, 6:44 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 10:18 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., David Woodhouse, (Mon Aug 4, 10:13 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Austin Zhang, (Tue Aug 5, 5:51 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 10:17 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., David Woodhouse, (Mon Aug 4, 6:12 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Austin Zhang, (Mon Aug 4, 6:35 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., David Woodhouse, (Mon Aug 4, 6:45 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Chris Mason, (Mon Aug 4, 9:45 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 11:42 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Benoit Boissinot, (Mon Aug 4, 2:02 pm)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 10:08 pm)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Chris Mason, (Mon Aug 4, 12:14 pm)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 12:45 pm)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Arjan van de Ven, (Mon Aug 4, 1:06 pm)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 1:10 pm)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 1:13 pm)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Helge Hafting, (Tue Aug 5, 7:10 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Tue Aug 5, 10:04 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 10:04 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Arjan van de Ven, (Mon Aug 4, 10:20 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 11:12 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., David Woodhouse, (Mon Aug 4, 10:49 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 10:54 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Austin Zhang, (Mon Aug 4, 6:58 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., David Woodhouse, (Mon Aug 4, 7:25 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Sebastian Siewior, (Mon Aug 4, 6:25 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., Herbert Xu, (Mon Aug 4, 6:48 am)

Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC3..., David Woodhouse, (Mon Aug 4, 6:27 am)

Navigation

Popular discussions


linux-kernel:
Greg Kroah-Hartman	[PATCH 008/196] Chinese: add translation of volatile-considered-harmful.txt
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg KH	Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in
Andrew Morton	-mm merge plans for 2.6.23
git:

linux-netdev:
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Herbert Xu	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Rémi Denis-Courmont	[PATCH 01/14] Phonet global definitions
openbsd-misc:

Colocation donated by:

Who's online

There are currently 3 users and 663 guests online.

Online users

Syndicate