Re: VolanoMark regression with 2.6.27-rc1

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Peter Zijlstra
Date: Sunday, August 3, 2008 - 11:54 pm

On Mon, 2008-08-04 at 11:23 +0530, Dhaval Giani wrote:


---
Subject: sched: scale sysctl_sched_shares_ratelimit with nr_cpus

David reported that his Niagra spend a little too much time in
tg_shares_up(), which considering he has a large cpu count makes sense.

So scale the ratelimit value with the number of cpus like we do for
other controls as well.

Reported-by: David Miller <davem@davemloft.net>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
diff --git a/kernel/sched.c b/kernel/sched.c
index 9a76e92..7eddaea 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -809,9 +809,9 @@ const_debug unsigned int sysctl_sched_nr_migrate = 32;
 
 /*
  * ratelimit for updating the group shares.
- * default: 0.5ms
+ * default: 0.25ms
  */
-const_debug unsigned int sysctl_sched_shares_ratelimit = 500000;
+const_debug unsigned int sysctl_sched_shares_ratelimit = 250000;
 
 /*
  * period over which we measure -rt task cpu usage in us.
@@ -5732,6 +5732,8 @@ static inline void sched_init_granularity(void)
 		sysctl_sched_latency = limit;
 
 	sysctl_sched_wakeup_granularity *= factor;
+
+	sysctl_sched_shares_ratelimit *= factor;
 }
 
 #ifdef CONFIG_SMP


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
VolanoMark regression with 2.6.27-rc1, Zhang, Yanmin, (Wed Jul 30, 8:20 pm)
Re: VolanoMark regression with 2.6.27-rc1, Zhang, Yanmin, (Thu Jul 31, 12:31 am)
Re: VolanoMark regression with 2.6.27-rc1, Peter Zijlstra, (Thu Jul 31, 12:39 am)
Re: VolanoMark regression with 2.6.27-rc1, Zhang, Yanmin, (Thu Jul 31, 12:49 am)
Re: VolanoMark regression with 2.6.27-rc1, Zhang, Yanmin, (Thu Jul 31, 5:39 pm)
Re: VolanoMark regression with 2.6.27-rc1, Miao Xie, (Thu Jul 31, 7:35 pm)
Re: VolanoMark regression with 2.6.27-rc1, Zhang, Yanmin, (Thu Jul 31, 8:08 pm)
Re: VolanoMark regression with 2.6.27-rc1, Dhaval Giani, (Thu Jul 31, 10:14 pm)
Re: VolanoMark regression with 2.6.27-rc1, Hugh Dickins, (Fri Aug 1, 5:25 am)
Re: VolanoMark regression with 2.6.27-rc1, Zhang, Yanmin, (Sun Aug 3, 5:54 pm)
Re: VolanoMark regression with 2.6.27-rc1, Zhang, Yanmin, (Sun Aug 3, 10:04 pm)
Re: VolanoMark regression with 2.6.27-rc1, Dhaval Giani, (Sun Aug 3, 10:22 pm)
Re: VolanoMark regression with 2.6.27-rc1, Zhang, Yanmin, (Sun Aug 3, 10:37 pm)
Re: VolanoMark regression with 2.6.27-rc1, Dhaval Giani, (Sun Aug 3, 10:53 pm)
Re: VolanoMark regression with 2.6.27-rc1, Peter Zijlstra, (Sun Aug 3, 11:26 pm)
Re: VolanoMark regression with 2.6.27-rc1, Peter Zijlstra, (Sun Aug 3, 11:26 pm)
Re: VolanoMark regression with 2.6.27-rc1, Peter Zijlstra, (Sun Aug 3, 11:54 pm)
Re: VolanoMark regression with 2.6.27-rc1, Dhaval Giani, (Mon Aug 4, 12:05 am)
Re: VolanoMark regression with 2.6.27-rc1, Peter Zijlstra, (Mon Aug 4, 12:12 am)
Re: VolanoMark regression with 2.6.27-rc1, Peter Zijlstra, (Fri Aug 8, 12:30 am)
Re: VolanoMark regression with 2.6.27-rc1, Ingo Molnar, (Fri Aug 15, 8:37 am)
Re: VolanoMark regression with 2.6.27-rc1, Zhang, Yanmin, (Mon Aug 5, 8:26 pm)
Re: VolanoMark regression with 2.6.27-rc1, Zhang, Yanmin, (Tue Aug 13, 1:50 am)