[PATCH] UBIFS: always read hashed-key nodes under TNC mutex

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Artem Bityutskiy
Date: Sunday, August 31, 2008 - 7:52 am

From: Adrian Hunter <ext-adrian.hunter@nokia.com>

Leaf-nodes that have a hashed key are stored in the
leaf-node-cache (LNC) which is protected by the TNC
mutex.  Consequently, when reading a leaf node with
a hashed key (i.e. directory entries, xattr entries)
the TNC mutex is always required.

Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
---
 fs/ubifs/tnc.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/fs/ubifs/tnc.c b/fs/ubifs/tnc.c
index e909f4a..4fbc592 100644
--- a/fs/ubifs/tnc.c
+++ b/fs/ubifs/tnc.c
@@ -1498,7 +1498,6 @@ static int do_lookup_nm(struct ubifs_info *c, const union ubifs_key *key,
 {
 	int found, n, err;
 	struct ubifs_znode *znode;
-	struct ubifs_zbranch zbr;
 
 	dbg_tnc("name '%.*s' key %s", nm->len, nm->name, DBGKEY(key));
 	mutex_lock(&c->tnc_mutex);
@@ -1522,11 +1521,7 @@ static int do_lookup_nm(struct ubifs_info *c, const union ubifs_key *key,
 		goto out_unlock;
 	}
 
-	zbr = znode->zbranch[n];
-	mutex_unlock(&c->tnc_mutex);
-
-	err = tnc_read_node_nm(c, &zbr, node);
-	return err;
+	err = tnc_read_node_nm(c, &znode->zbranch[n], node);
 
 out_unlock:
 	mutex_unlock(&c->tnc_mutex);
-- 
1.5.4.1

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: UBIFS updates for 2.6.27, Artem Bityutskiy, (Sun Aug 31, 7:32 am)
UBIFS updates for 2.6.27, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: fix zero-length truncations, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: always read hashed-key nodes under TNC mutex, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: allow for racing between GC and TNC, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: do not update min_idx_lebs in stafs, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: push empty flash hack down, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: remove incorrect index space check, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: improve statfs reporting, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: fix assertion, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: add forgotten gc_idx_lebs component, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: introduce LEB overhead, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: improve statfs reporting even more, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
[PATCH] UBIFS: fill f_fsid, Artem Bityutskiy, (Sun Aug 31, 7:52 am)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Mon Sep 1, 2:43 am)
Re: [PATCH] UBIFS: fill f_fsid, Artem Bityutskiy, (Mon Sep 1, 4:16 am)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Mon Sep 1, 4:28 am)
Re: [PATCH] UBIFS: fill f_fsid, Artem Bityutskiy, (Mon Sep 1, 4:43 am)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Mon Sep 1, 4:50 am)
Re: [PATCH] UBIFS: fill f_fsid, Artem Bityutskiy, (Mon Sep 1, 4:56 am)
Re: [PATCH] UBIFS: fill f_fsid, Christoph Hellwig, (Mon Sep 1, 8:01 am)
Re: [PATCH] UBIFS: fill f_fsid, Artem Bityutskiy, (Tue Sep 2, 12:03 am)
Re: [PATCH] UBIFS: fill f_fsid, Andreas Dilger, (Tue Sep 2, 10:09 am)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Tue Sep 2, 10:29 am)
Re: [PATCH] UBIFS: fill f_fsid, Andreas Dilger, (Tue Sep 2, 12:13 pm)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Tue Sep 2, 12:32 pm)
Re: [PATCH] UBIFS: fill f_fsid, Christoph Hellwig, (Tue Sep 2, 2:02 pm)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Tue Sep 2, 2:26 pm)
Re: [PATCH] UBIFS: fill f_fsid, Christoph Hellwig, (Tue Sep 2, 2:48 pm)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Tue Sep 2, 3:12 pm)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Tue Sep 2, 3:32 pm)
Re: [PATCH] UBIFS: fill f_fsid, Artem Bityutskiy, (Tue Sep 2, 11:20 pm)
Re: [PATCH] UBIFS: fill f_fsid, Artem Bityutskiy, (Wed Sep 3, 2:44 am)
Re: [PATCH] UBIFS: fill f_fsid, David Woodhouse, (Wed Sep 3, 3:14 am)