Re: [REGRESSION 2.6.27-rc4-git7] mtd broken by cmdfilter move

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Greg KH <gregkh@...>
Cc: Mikael Pettersson <mikpe@...>, <fujita.tomonori@...>, <dwmw2@...>, <jens.axboe@...>, <linux-kernel@...>
Date: Saturday, August 30, 2008 - 2:07 pm

Greg KH writes:
> > --- linux-2.6.27-rc4-git6/block/cmd-filter.c.~1~ 2008-08-30 17:08:58.000000000 +0200
> > +++ linux-2.6.27-rc4-git6/block/cmd-filter.c 2008-08-30 17:36:36.000000000 +0200
> > @@ -215,6 +215,13 @@ int blk_register_filter(struct gendisk *
> > if (!parent)
> > return -ENODEV;
> >
> > + printk("%s: disk %p queue %p filter %p &filter->kobj %p\n",
> > + __func__, disk, disk->queue, filter, &filter->kobj);
> > + if (filter->kobj.state_initialized) {
> > + printk("%s: kobj %p already inited, bailing out\n",
> > + __func__, &filter->kobj);
> > + return 0;
> > + }
>
> Ick, no, don't go poking into the internals of a kobject like this to
> fix this kind of problem. If you really don't know if you have
> initialized this kobject or not, then you will have reference counting
> problems, which need to be fixed for real.

This was a debug patch, I wasn't suggesting it as "the" fix.
--

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[REGRESSION 2.6.27-rc4-git7] mtd broken by cmdfilter move, Mikael Pettersson, (Sat Aug 30, 1:04 pm)
Re: [REGRESSION 2.6.27-rc4-git7] mtd broken by cmdfilter move, Mikael Pettersson, (Sat Aug 30, 2:07 pm)
Re: [REGRESSION 2.6.27-rc4-git7] mtd broken by cmdfilter move, Mikael Pettersson, (Sat Aug 30, 2:10 pm)
Re: [REGRESSION 2.6.27-rc4-git7] mtd broken by cmdfilter move, Mikael Pettersson, (Sat Aug 30, 4:00 pm)