[PATCH] scsi/sd: Fix size output in MB

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Simon Arlott
Date: Saturday, August 30, 2008 - 7:08 am

The capacity printk'd in bytes is divided by 1000000,
whereas 1048576 would be more consistent with the rest
of the OS and disk-related utilities ('df' etc.).

This change replaces the (sz - (sz/625 - 974))/1950
calculation with a simple right shift by 11 bits
(/2048).

Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
---
 drivers/scsi/sd.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index e5e7d78..e6fd6fd 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1441,10 +1441,8 @@ got_data:
 		sector_t mb = sz;
 
 		blk_queue_hardsect_size(queue, hard_sector);
-		/* avoid 64-bit division on 32-bit platforms */
-		sector_div(sz, 625);
-		mb -= sz - 974;
-		sector_div(mb, 1950);
+		/* Convert to megabytes (/2048) */
+		mb = sz >> 11;
 
 		sd_printk(KERN_NOTICE, sdkp,
 			  "%llu %d-byte hardware sectors (%llu MB)\n",
-- 
1.5.6.5

-- 
Simon Arlott



--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] scsi/sd: Fix size output in MB, Simon Arlott, (Sat Aug 30, 7:08 am)
Re: [PATCH] scsi/sd: Fix size output in MB, James Bottomley, (Sat Aug 30, 10:24 am)
Re: [PATCH] scsi/sd: Fix size output in MB, Matthew Wilcox, (Sat Aug 30, 10:45 am)
Re: [PATCH] scsi/sd: Fix size output in MB, Pierre Ossman, (Sat Aug 30, 1:59 pm)
Re: [PATCH] scsi/sd: Fix size output in MB, Simon Arlott, (Sat Aug 30, 2:02 pm)
Re: [PATCH] scsi/sd: Fix size output in MB, James Bottomley, (Sat Aug 30, 2:45 pm)
Re: [PATCH] scsi/sd: Fix size output in MB, Matthew Wilcox, (Sat Aug 30, 2:57 pm)
Re: [PATCH] scsi/sd: Fix size output in MB, Pierre Ossman, (Sat Aug 30, 3:13 pm)
Re: [PATCH] scsi/sd: Fix size output in MB, Simon Arlott, (Sat Aug 30, 3:22 pm)
Re: [PATCH] scsi/sd: Fix size output in MB, Simon Arlott, (Sat Aug 30, 3:24 pm)
Re: [PATCH] scsi/sd: Fix size output in MB, Matthew Wilcox, (Sat Aug 30, 3:36 pm)
Re: [PATCH] scsi/sd: Fix size output in MB, James Smart, (Sun Aug 31, 5:27 am)
[PATCH] mmc_block: use generic helper to print capacities, Pierre Ossman, (Sun Aug 31, 11:54 am)