Apply the io-throttle controller to the opportune kernel functions. Both accounting and throttling functionalities are performed by cgroup_io_throttle(). Signed-off-by: Andrea Righi <righi.andrea@gmail.com> --- block/blk-core.c | 9 +++++++++ fs/aio.c | 31 ++++++++++++++++++++++++++++++- fs/buffer.c | 20 +++++++++++++++++--- fs/direct-io.c | 4 ++++ include/linux/sched.h | 3 +++ kernel/fork.c | 4 +++- mm/filemap.c | ...

Documentation of the block device I/O controller: description, usage, advantages and design. Signed-off-by: Andrea Righi <righi.andrea@gmail.com> --- Documentation/controllers/io-throttle.txt | 312 +++++++++++++ block/blk-io-throttle.c | 719 +++++++++++++++++++++++++++++ include/linux/blk-io-throttle.h | 41 ++ 3 files changed, 1072 insertions(+), 0 deletions(-) create mode 100644 Documentation/controllers/io-throttle.txt create mode 100644 ...

This is just a small selection of four fixes, one expanding driver bindings and the other three fixing actual bugs (all of which need backporting to 2.6.26 I'm afraid). The patch is available here: master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git The short changelog is: HighPoint Linux Team (1): hptiop: add more PCI device IDs James Bottomley (2): scsi_transport_spi: fix oops in revalidate ses: fix VPD inquiry overrun Tim Wright (1): ...

Hi, scripts/patch-kernel script can't patch a tree, say, from 2.6.25 to 2.6.26.1, because of a wrong comparison in context of patching 2.6.x base. Following patch has a fix for it. Erkki --- linux-2.6.26/scripts/patch-kernel 2008-04-27 19:49:14.000000000 +0300 +++ linux-2.6.26.1/scripts/patch-kernel 2008-08-03 23:34:00.000000000 +0300 @@ -213,6 +213,7 @@ if [ $stopvers != "default" ]; then STOPSUBLEVEL=`echo $stopvers | cut -d. -f3` STOPEXTRA=`echo $stopvers | ...

Replacing the normal build output with something different doesn't make anything easier. Especially considering that your "once the .config file is set" seems to cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed --

From: Randy Dunlap <randy.dunlap@oracle.com> Fix handling of nested structs or unions. The regex to strip (eliminate) nested structs or unions was limited to only 0 or 1 matches. This can cause an uneven number of left/right braces to be stripped, which causes this: Warning(linux-2.6.27-rc1-git2//include/net/mac80211.h:336): No description found for parameter '}' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- scripts/kernel-doc | 2 +- 1 file changed, 1 insertion(+), 1 ...

Hi, what is this device attached to this port ? Do you have the device attached before turning on the machine ? Does it happen if you boot without that device attached and attach it afterwards ? Can you please enable CONFIG_USB_DEBUG and resend dmesg output ? thanks, -- balbi --

From: Stephen Rothwell <sfr@canb.auug.org.au> So copy their contents into the asm-m68k files. Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- include/asm-m68k/contregs.h | 51 ++++++ include/asm-m68k/fbio.h | 331 +++++++++++++++++++++++++++++++++++++++++++- include/asm-m68k/idprom.h | 21 ++ 3 files changed, 400 insertions(+), 3 deletions(-) --- a/include/asm-m68k/contregs.h +++ ...

Вітаємо, Владимир Кирилов! Пропонуємо до вашої уваги перелік найбільш цікавих подій на Коннекті за останній час: Близько тижня тому змінився зовнішній вигляд Коннекту. Судячи по відгуках, багатьом він припав до душі. Крім того, ми істотно переробили розділ "Фото". Найближчим часом на Коннекті з`явиться дуже бажана для багатьох функція - завантаження аудіо. Ви зможете додавати свою улюблену музику собі в анкету, до групи і т. д. Не за горами також поява новин, ігор, істотне поліпшення пошуку людей, ...

From: Max Krasnyansky <maxk@qualcomm.com> Fixed in current GIT. --

Hi I noticed that 2.6.27-rc1+ (2b12a4c524812fb3f6ee590a02e65b95c8c32229) prints this: Completing Region/Field/Buffer/Package initialization:.ACPI Error (dsobject-0501): Package List length (EA) larger than NumElements count (3), truncated Is it something to worry about? I've put full log, config and acpidump on http://www.kadu.net/~joi/kernel/2008.08.03/ Marcin --

Well, this is the usual trouble. I don't have a misbehaving motherboard, so I artificially induce MSI problems on my platform. For me, it works, but obviously I'm losing every MSI interrupt. James --

Thanks, I will try this out. However I thought I saw lost interrupts occurring randomly, meaning it was not necessarily the first config page access. I'm back in the office on 8/11, I will test it out then and provide feedback. Eric ________________________________________ From: James Bottomley [James.Bottomley@HansenPartnership.com] Sent: Sunday, August 03, 2008 12:05 PM To: linux-scsi; linux-kernel; linux-pci@vger.kernel.org Cc: Moore, Eric Subject: [PATCH 2/2] fusion: Implement generic ...

Change the code to get/put timer->it_process regardless of SIGEV_THREAD_ID. This streamlines the create/destroy paths and allows us to simplify the usage of exit_itimers() in de_thread(). Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> --- 26-rc2/kernel/posix-timers.c~2_GET_LEADER 2008-08-03 20:25:41.000000000 +0400 +++ 26-rc2/kernel/posix-timers.c 2008-08-03 21:13:25.000000000 +0400 @@ -540,11 +540,10 @@ sys_timer_create(const clockid_t which_c */ ...

de_thread() postpones release_task(leader) until after exit_itimers(). This was needed because !SIGEV_THREAD_ID timers could use ->group_leader without get_task_struct(). With the recent changes we can release the leader earlier and simplify the code. Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> --- 26-rc2/fs/exec.c~3_DE_THREAD 2008-08-03 17:16:40.000000000 +0400 +++ 26-rc2/fs/exec.c 2008-08-03 21:35:33.000000000 +0400 @@ -757,7 +757,6 @@ static int de_thread(struct task_struct struct ...

Haven't actually looked, but you should've probably waited just a bit for people to start using and then getting fed up with kgdb... Rene. --

Hi, I get lots of errors like this with 2.6.27-rc1 on my Macbook Pro (3rd generation), 2.6.26 seems to work fine: [ 907.524509] DMA: Out of SW-IOMMU space for 45056 bytes at device 0000:00:1f.2 [ 907.524783] ata3.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x0 [ 907.524796] ata3.00: cmd 35/00:50:08:91:5c/00:01:0f:00:00/e0 tag 0 dma 172032 out [ 907.524798] res 50/00:00:ff:90:5c/00:00:0f:00:00/ef Emask 0x40 (internal error) [ 907.524805] ata3.00: status: { DRDY } [ ...

I should stop for today, it's e84f84f276473dcc673f360e8ff3203148bdf0e2 that has the &net->ipv4.rt_genid in rt_cache_invalidate(). ... --

Yes, I have this in sysctl.conf: $ grep "ip_default_ttl" /etc/sysctl.conf Thanks, now it works. Tested-by: Marcin Slusarz <marcin.slusarz@gmail.com> Marcin --

Actually it's 86c657f6b5bbf2f3ec2213eca528998134a9b344, 76e6ebf adds the initial code that accesses the extra2 parameter, but 86c657f adds the --

Acked-by: Denis V. Lunev <den@openvz.org> --

Yes. Thanks for looking at the patch! --- From c6e673acf02e8bf04866cadf17c1cb1fa4d852ea Mon Sep 17 00:00:00 2001 From: Marcin Slusarz <marcin.slusarz@gmail.com> Subject: [PATCH] x86, acpi: temp_stack is used only when CONFIG_64BIT && CONFIG_SMP is set arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> Cc: Glauber Costa <gcosta@redhat.com> Cc: Pavel Machek <pavel@suse.cz> Cc: Ingo Molnar ...

Now it still generates the warning, but on i386 with CONFIG_SMP set, instead of x86_64 without CONFIG_SMP. We only need temp_stack, when both CONFIG_64BIT and CONFIG_SMP are activated. Sven --

gcc warns about it: sound/core/pcm_native.c: In function 'snd_pcm_fasync': sound/core/pcm_native.c:3262: warning: label 'out' defined but not used Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> Cc: Takashi Iwai <tiwai@suse.de> Cc: Jaroslav Kysela <perex@perex.cz> --- sound/core/pcm_native.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index c49b9d9..333cff6 100644 --- a/sound/core/pcm_native.c +++ ...

And that is broken. That's not what an assert is for, we access substream->runtime a line later and that will blow up. That should be a simpe if, instead of an assert. Sven --

From: Dmitry Adamushko <dmitry.adamushko@gmail.com> Run ucode-updates via workqueue (keventd) instead of using set_cpus_allowed_ptr() in cpu-hotplug handlers. The target 'cpu' is not yet 'active' when set_cpu_allowed_ptr() gets called from mc_cpu_callback() (i.e. tasks can't be migrated onto it). This caused a bug#11197: http://www.ussg.iu.edu/hypermail/linux/kernel/0807.3/3791.html) (Almost)-Signed-off-by: Dmitry Adamushko <dmitry.adamushko@gmail.com> --- commit ...

I have one of those too (pdc202xx craps itself with the new drivers). -- dwmw2 --

I'm using gmail's interface (I don't have access to my laptop ATM) so the mail may look a bit weird... On Sun, Aug 3, 2008 at 5:57 PM, James Bottomley This claim doesn't seem to have confirmation in facts: * There is still hardware that is simply not-supported by libata at all: - architecture specific hardware (ppc, m68k, mips, arm) - "difficult" legacy PC-class hardware (i.e. secondary interface on CY82C693 etc) * There are still regressions in many libata PCI host drivers ...

I'd be a bit surprised if that's anything other than a niche. PIO is deadly slow and wasteful of precious CPU cycles ... and embedded devices seem to be interested in performance as well (which the DMA modes Hey, I'd be the last person to discourage anyone from maintaining obsolete systems ... however, the outside world looking in on this is interested to know where they should be starting if they have some type of CF/IDE device to support. What we really want to avoid is someone spending ...

Well, I know of at least one case of PC hardware in which an old IDE driver basically works while the libata/pata poeple have no idea why their driver doesn't: http://bugzilla.kernel.org/show_bug.cgi?id=9157 Thanks, Rafael --

Sounds about right for a typical device based upon the ones I did that way. --

I'm not in any rush to change the status quo as I see it: don't remove drivers/ide but encourage new drivers to be under libata. I am a bit disappointed at all the drivers/ide churn. I had hoped it would sit around and be a stable alternative, a fallback to libata. Jeff --

Hmm, OK, but I did see (as you note below) that mac ide doesn't work Yes, I understand this ... if that means drivers/ata can't possibly be used by embedded until its dependence on SCSI is broken, then so be it ... but I think we should at least investigate what the issues and Well, I did notice from the lists that both drivers/ide and drivers/ata would be represented. I've also observed that there's been a singular lack of discussion of this on the lists; plus it's the type of ...

From: Dmitry Adamushko <dmitry.adamushko@gmail.com> (1) Introduce microcode_update_cpu() which is a generic routine to do ucode-updates (for both bootup-path and system-resume-path); (2) Adapt the logic of cpu-hotplug handlers; (3) Fix a race with sched_setaffinity() in reload_store() We introduce another mechanism to run ucode-updates on a target cpu to replace set_cpus_allowed_ptr() being called from cpu-hotplug events (which causes a bug#11197: ...

Ben, please use this version instead (together with ide_host_alloc_all() fix) for media-bay testing. From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Subject: [PATCH] ide: fix regression caused by ide_device_{get,put}() addition (take 2) On Monday 28 July 2008, Benjamin Herrenschmidt wrote: The guilty commit turned out to be 08da591e14cf87247ec09b17c350235157a92fc3 ("ide: add ide_device_{get,put}() helpers"). ide_device_put() is called before kref_put() in ide_cd_put() so IDE ...

By introducing the macroses __setup_alias and early_param_alias we are allowed to use boot param aliases. Here is an example: static int __init parse_func(char *arg) { /* set some flag or do something */ return 0; } early_param("param1", parse_func); early_param_alias("param1-alias", parse_func); Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- I found it usefull while was looking for APIC code merging. Please review! Any comments are _quite_welcome_!!! I use __LINE__ ...

Alan, Here is a patch for you. Tested with 1) CONFIG_SUSPEND, CONFIG_HIBERNATION i.e. with CONFIG_PM_SLEEP 2) without CONFIG_PM_SLEEP but with CONFIG_PM 3) without CONFIG_PM Thanks, -Romit Description: Fixes missing PM entries in sysfs without CONFIG_PM_SLEEP. Signed-off-by: Romit Dasgupta <romit@ti.com> diff --git a/drivers/base/power/power.h b/drivers/base/power/power.h index a3252c0..ad8112d 100644 --- a/drivers/base/power/power.h +++ b/drivers/base/power/power.h @@ -1,3 ...

Resend of the patch to remove the following warning: drivers/acpi/sbs.c: In function 'acpi_battery_remove': drivers/acpi/sbs.c:819: warning: unused variable 'battery' Signed-off-by:- "Manish Katiyar" <mkatiyar@gmail.com> --- drivers/acpi/sbs.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c index 10a3651..8493603 100644 --- a/drivers/acpi/sbs.c +++ b/drivers/acpi/sbs.c @@ -816,7 +816,9 @@ static int ...

I'm not have much experience with linux kernel architecture, so I don't know where I can focus on. Currently, I'm suspecting these module are affected with this Oops: Block I/O management and filesystem, some Wait Queue ? Is that correct ? Or would you give me some suggestion what is the most suspicious ? or some debugging option you told above ? Thanks for your help, -- nm. GPG Key ID: 0xDD253B25 Fingerprint: 2B17 D64A 9561 A443 2ABC 1302 4641 D0B7 DD25 3B25 --

Hi all, I’m using kernel 2.4.20 with fully preemptive enable (patch & set the CONFIG option). My CPU is PowerPC 750FX, HDD 80GB, RAM 512, I got many Oops when try to mount/unmount or read/write on ATA HDD continuously about 600.000 times (in several hours). Oops often occurred when CPU trap SIGSEGV or SIGILL, sometime on page management module, sometimes on scheduler, block I/O manipulation, filesystem. The most frequently happened on: Block I/O : make_request, generic_make_request, ...

On Sun, 03 Aug 2008 14:18:04 +0200 ioctl_by_bdev is calling ioctl methods with filp = NULL which is not valid. That in turn blocks switching to unlocked_ioctl and BKL removal so ioctl_by_bdev urgently needs fixing. Alan --

Dump of assembler code for function exportfs_decode_fh: 0xc015b7cc <exportfs_decode_fh+0>: mflr r0 0xc015b7d0 <exportfs_decode_fh+4>: stw r0,4(r1) 0xc015b7d4 <exportfs_decode_fh+8>: bl 0xc0013154 <_mcount> 0xc015b7d8 <exportfs_decode_fh+12>: stwu r1,-304(r1) 0xc015b7dc <exportfs_decode_fh+16>: mflr r0 0xc015b7e0 <exportfs_decode_fh+20>: stmw r22,264(r1) 0xc015b7e4 <exportfs_decode_fh+24>: mr r27,r3 0xc015b7e8 <exportfs_decode_fh+28>: ...

Hi, I have an Intel Core 2 Quad and running kernel 2.6.25.11-97.fc9.i686. cpufreq doesn't seem to work. The cpufreq scaling monitor in Gnome says CPU Freq scaling is not supported in my CPU. The CPU can run at 2.0 and 2.5 GHz but mine always runs at 2.5 GHz in Linux. So I checked /sys and there is no cpufreq dir in /sys/... # ls /sys/devices/system/cpu/ cpu0 cpu1 cpu2 cpu3 cpuidle sched_mc_power_savings # ls /sys/devices/system/cpu/cpuidle/ current_driver ...

Hello, http://google-perftools.googlecode.com/svn-history/r48/trunk/src/base/atomicops-intern... says " // Opteron Rev E has a bug in which on very rare occasions a locked // instruction doesn't act as a read-acquire barrier if followed by a // non-locked read-modify-write instruction. Rev F has this bug in // pre-release versions, but not in versions released to customers, // so we test only for Rev E, which is family 15, model 32..63 inclusive. if (strcmp(vendor, ...

Until ftrace gains this ability, you could use systemtap: # cat callret.stp probe $1.call { printf ("%s <- %s\n", thread_indent(1), probefunc()) } probe $1.return { printf ("%s -> %s\n", thread_indent(-1), probefunc()) } # stap callret.stp 'module("usbcore").function("*")' [...] ^C # (One can also add conditions based on function parameters, processes, whatever; soon it'll be easy to trace all function parameters.) - FChE --

You can do that at compile time only by selective compilation of files/modules which need to be traced with the -pg CFLAG. For instance, the inlined patch enables tracing of all functions in softirq.o only. Regards, Abhishek Sagar -- ## For testing only diff --git a/Makefile b/Makefile index 40f2481..09d216b 100644 --- a/Makefile +++ b/Makefile @@ -532,10 +532,6 @@ KBUILD_CFLAGS += -g KBUILD_AFLAGS += -gdwarf-2 endif -ifdef CONFIG_FTRACE -KBUILD_CFLAGS += ...

I don't think you can use || operator in ifdef like that... ...Try #if defined(...) || (...) instead. -- i. --

Did the patch sumbitter try to build this with the patch in place??? --=20 ~Randy

I can trigger it reliably with a 2.6.26 client. I've also triggered it with 496d6c32d4d057cb44272d9bd587ff97d023ee92 reverted on the server. It's harder to trigger with 2.6.27-rc1+ but I managed to get an Oops on the fourth build after three successful builds on the NFS4 mount. One of the Oopses I got with 2.6.26 had a slightly different call trace: Unable to handle kernel paging request for instruction fetch Faulting instruction address: 0x00000000 Oops: Kernel access of bad area, sig: ...

delete old timer handler. Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> diff --git a/arch/h8300/platform/h8300h/aki3068net/Makefile b/arch/h8300/platform/h8300h/aki3068net/Makefile index b03c328..b7ff780 100644 --- a/arch/h8300/platform/h8300h/aki3068net/Makefile +++ b/arch/h8300/platform/h8300h/aki3068net/Makefile @@ -3,4 +3,3 @@ # extra-y := crt0_ram.o -obj-y := timer.o diff --git a/arch/h8300/platform/h8300h/aki3068net/timer.c ...

- Update selection - Update common timer handler - Add support functions Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> diff --git a/arch/h8300/Kconfig.cpu b/arch/h8300/Kconfig.cpu index 582797d..b65dcfe 100644 --- a/arch/h8300/Kconfig.cpu +++ b/arch/h8300/Kconfig.cpu @@ -1,5 +1,7 @@ menu "Processor type and features" +source "kernel/time/Kconfig" + choice prompt "H8/300 platform" default H8300H_GENERIC @@ -11,6 +13,7 @@ config H8300H_GENERIC config ...

Use common Kconfig file. Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> arch/h8300/Kconfig | 116 +--------------------------------------------------- 1 files changed, 1 insertions(+), 115 deletions(-) diff --git a/arch/h8300/Kconfig b/arch/h8300/Kconfig index 396ab05..adeac03 100644 --- a/arch/h8300/Kconfig +++ b/arch/h8300/Kconfig @@ -99,121 +99,7 @@ endmenu source "net/Kconfig" -source "drivers/base/Kconfig" - -source "drivers/mtd/Kconfig" - -source ...

this one is applied before removing NR_IRQS usage in array definition. YH --

use small array with index to handle irq locking for serial port hope 32 slot is enough v2: according to Eric, move irq_no into irq_info, and not clean irq_no Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> --- drivers/serial/8250.c | 45 +++++++++++++++++++++++++++++++++++++++++---- 1 files changed, 41 insertions(+), 4 deletions(-) diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 3920324..595b956 100644 --- ...

That is the general idea. Eric --

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- drivers/char/random.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/char/random.c b/drivers/char/random.c index fdbdcfc..872669e 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -558,7 +558,13 @@ struct timer_rand_state { }; static struct timer_rand_state input_timer_state; + +#ifdef CONFIG_HAVE_DYN_ARRAY +static struct timer_rand_state ...

so could spare some memory with small alignment in bootmem also tighten the alignment checking..., and make print out less debug info Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- arch/x86/kernel/setup_percpu.c | 16 +++++++--- include/linux/init.h | 2 +- init/main.c | 65 ++++++++++++++++++++++++++++++--------- 3 files changed, 62 insertions(+), 21 deletions(-) diff --git a/arch/x86/kernel/setup_percpu.c b/arch/x86/kernel/setup_percpu.c index ...

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- arch/x86/kernel/io_apic_32.c | 54 +++++++++++++++++++++++++++++++++-------- arch/x86/kernel/io_apic_64.c | 28 ++++++++++++++++----- arch/x86/kernel/setup.c | 6 ++++ 3 files changed, 70 insertions(+), 18 deletions(-) diff --git a/arch/x86/kernel/io_apic_32.c b/arch/x86/kernel/io_apic_32.c index d5953ff..a0ce64c 100644 --- a/arch/x86/kernel/io_apic_32.c +++ b/arch/x86/kernel/io_apic_32.c @@ -70,7 +70,7 @@ int ...

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- drivers/char/hpet.c | 2 +- drivers/char/random.c | 4 ++-- drivers/char/vr41xx_giu.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c index 2908a0e..8d562ae 100644 --- a/drivers/char/hpet.c +++ b/drivers/char/hpet.c @@ -219,7 +219,7 @@ static void hpet_timer_set_irq(struct hpet_dev *devp) for (irq = find_first_bit(&v, HPET_MAX_IRQ); irq < ...

Dhaval Giani got: kernel BUG at arch/x86/kernel/io_apic_64.c:357! invalid opcode: 0000 [1] SMP CPU 24 ... his system (x3950) has 8 ioapic, irq > 256 caused by commit 9b7dc567d03d74a1fbae84e88949b6a60d922d82 Author: Thomas Gleixner <tglx@linutronix.de> Date: Fri May 2 20:10:09 2008 +0200 x86: unify interrupt vector defines The interrupt vector defines are copied 4 times around with minimal differences. Move them all into ...

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- arch/x86/kernel/acpi/boot.c | 30 ++++++++++++++++++++++++++++-- include/asm-x86/mpspec.h | 1 + 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c index 27ef365..443cb30 100644 --- a/arch/x86/kernel/acpi/boot.c +++ b/arch/x86/kernel/acpi/boot.c @@ -962,6 +962,29 @@ void __init mp_register_ioapic(int id, u32 address, u32 gsi_base) nr_ioapics++; } +int ...

no user Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- include/asm-x86/mach-generic/irq_vectors_limits.h | 14 -------------- include/asm-x86/summit/irq_vectors_limits.h | 14 -------------- 2 files changed, 0 insertions(+), 28 deletions(-) delete mode 100644 include/asm-x86/mach-generic/irq_vectors_limits.h delete mode 100644 include/asm-x86/summit/irq_vectors_limits.h diff --git a/include/asm-x86/mach-generic/irq_vectors_limits.h ...

should be 05 YH --

04 fix that via allocating that all together YH --

Hi, I didn't mean da->name. Please reread my email, including the part you Hannes --

could have crazy big arrays and allocate them in bootmem at init stage. also also to allocate array according to size we need to use to avoid wasting memory use CONFIG_HAVE_DYN_ARRAY to enable it or not usage: |static struct irq_desc irq_desc_init __initdata = { | .status = IRQ_DISABLED, | .chip = &no_irq_chip, | .handle_irq = handle_bad_irq, | .depth = 1, | .lock = __SPIN_LOCK_UNLOCKED(irq_desc->lock), |#ifdef CONFIG_SMP | .affinity = ...

could use pre_allocate array + list to replace irq_desc array. YH --

also add first_free_entry and pin_map_size Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- arch/x86/kernel/io_apic_32.c | 26 ++++++++++++++------------ arch/x86/kernel/io_apic_64.c | 33 +++++++++++++++++---------------- arch/x86/kernel/irq_32.c | 8 ++++---- arch/x86/kernel/irq_64.c | 8 ++++---- arch/x86/kernel/irqinit_32.c | 2 +- arch/x86/kernel/irqinit_64.c | 2 +- include/asm-x86/irq.h | 3 +++ 7 files changed, 44 insertions(+), 38 ...

On Sat, Aug 2, 2008 at 11:39 PM, Eric W. Biederman how about diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c index f4c8a03..aa6888c 100644 --- a/kernel/irq/handle.c +++ b/kernel/irq/handle.c @@ -47,19 +47,73 @@ handle_bad_irq(unsigned int irq, struct irq_desc *desc) * * Controller mappings for all interrupt sources: */ -struct irq_desc irq_desc[NR_IRQS] __cacheline_aligned_in_smp = { - [0 ... NR_IRQS-1] = { - .status = IRQ_DISABLED, - .chip ...

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- fs/proc/proc_misc.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/proc/proc_misc.c b/fs/proc/proc_misc.c index ded9698..1968251 100644 --- a/fs/proc/proc_misc.c +++ b/fs/proc/proc_misc.c @@ -503,7 +503,7 @@ static int show_stat(struct seq_file *p, void *v) struct timespec boottime; unsigned int *per_irq_sum; - per_irq_sum = kzalloc(sizeof(unsigned int)*NR_IRQS, GFP_KERNEL); + per_irq_sum = ...

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> --- drivers/xen/events.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/xen/events.c b/drivers/xen/events.c index a083703..8e329c2 100644 --- a/drivers/xen/events.c +++ b/drivers/xen/events.c @@ -139,7 +139,7 @@ static void init_evtchn_cpu_bindings(void) #ifdef CONFIG_SMP int i; /* By default all event channels notify CPU#0. */ - for (i = 0; i < NR_IRQS; i++) + for (i = 0; i < nr_irqs; ...

you can not pass compiling +#define DEFINE_DYN_ARRAY(nameX, sizeX, nrX, alignX, init_workX) \ + static struct dyn_array __dyn_array_##nameX __initdata = \ + { .name = (void **)&nameX,\ + .size = sizeX,\ + .nr = &nrX,\ + .align = alignX,\ + .init_work = init_workX,\ + }; \ + static struct dyn_array *__dyn_array_ptr_##nameX __used \ + ...

Hi, ... Hannes --

could make array in per_cpu is allocated dynamically too usage: | /* in .h */ |struct kernel_stat { | struct cpu_usage_stat cpustat; | unsigned int *irqs; |}; | | /* in .c */ |DEFINE_PER_CPU(struct kernel_stat, kstat); | |DEFINE_PER_CPU_DYN_ARRAY_ADDR(per_cpu__kstat_irqs, per_cpu__kstat.irqs, sizeof(unsigned int), nr_irqs, sizeof(unsigned long), NULL); after setup_percpu()/per_cpu_alloc_dyn_array(), that dyn_array in per_cpu area is ready to use Signed-off-by: Yinghai Lu ...

Hi, Exactly. Now, look up the possible return values of __alloc_bootmem_nopanic and we are almost there... Hannes --

On Sat, Aug 2, 2008 at 10:51 PM, Eric W. Biederman is_irq_valid(irq_no) ? wait to see your new patchset about dyn irq_cfg and irq_desc YH --

Could you please include the expected diffstat too? I can match up the shortlog to the expected thing, and see that I got what you intended for me, but the thing I actually _care_ much more deeply about is that it only touched ext4 (and jbd2) in this case. So I like matching up the diffstat, with the shortlog being just secondary. Linus --

Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git for_linus This patch series contains a number of bug fixes that have been discovered by primarily by benchmarkers and people who have been trying out ext4. A few cleanups have been included as well. Thanks!! - Ted Aneesh Kumar K.V (5): ext4: Fix data corruption when writing to prealloc area ext4: Improve error handling in ...

As I see it the main problems are: -Unless the ioctl parameter structures are laid out carefully, you end up with problems like different structure layouts between 32/64-bit processes, etc. -They can't really be used by anything other than a C or C++ program. Anything else (shell script, Python, Java, etc.) is pretty much out of Quite likely. For something like a status that's being read out of the device, a sysfs file would seem a more logical choice. If you're sitting there ...

Looking at this a bit more deeply, it seems to be a simple abuse of a semaphore. It's used both to exclude other tasks in salinfo_event_read() and as a wake queue from interrupt context. I think what we want is something more like this: spin_lock(&data_saved_lock); if (!worktodo) { if (O_NONBLOCK) spin_unlock() return; else add to wait queue spin_unlock() schedule() spin_lock() } Then we can just use wake_up() from interrupt context. Thoughts? I ...

Cannot happen. See the comment above the function: This routine must be called with data_saved_lock held, to make the down/up operation atomic --

Thanks. --

Yes, it is CONFIG_BLOCK=n. Thanks. --

I suppose if you always grep with context there's no problem? It's the only file I found with this issue while doing other stuff. Grant. --

Brian Beattie writes: > The other day Linus (I think) made the statement, that I don't disagree > with, that I will parapharse as "ioctl's suck". If I recall correctly > and understand he was saying that a device that uses ioctls is broken. ... > I could add a control device and pass ascii strings for status and OOB > messages, would that be an improvement? The problem is that the classical unix I/O abstraction really only handles two cases well, viz. "read next chunk of data" and "write ...

I agree. Perhaps the changelog was badly written... These 2 patches are just cleanups which remove the dead code, this is not the -stable material. Oleg. --

This should be an array in the first place... -hpa --

On Sun, Aug 3, 2008 at 1:54 PM, Krzysztof Halasa <khc@pm.waw.pl> wrote: _much worse_? Wow, I thought the opposite. Anyway, that's just a coding style patch, feel free to simply not apply it as it's really a matter of personal taste but be sure that I'm not blindly changing the code accordingly to checkpatch. That might be almost true when I started doing this kind of patches months ago but it's definitely not true anymore. Thanks. regards, -- ...

--

Please keep listed. The problem and patch are recently confirmed by Hugh Dickins (on LKML) and Dionisus Torimens (bugzilla duplicate). Ta Alan --

Thanks for reviewing the patch. I'll take a look into converting it to use new PM infrastructure (it may take a while so please be patient). --

Yep - I arrived at the same conclusion and sent a patch few minutes before I saw your mail. I am clueless about V4L and gspca workings but I chose a different approach to fix this - Sounds more appropriate but I am not sure how vidioc_s_ctrl leads to the call trace in the OOPS - at least it doesn't show up there. Thanks Parag --

I'm not familiar with v4l, but I'll take a crack at this. This decodes to: 3: 0f b6 90 da 07 00 00 movzbl 0x7da(%eax),%edx a: 8b a8 04 02 00 00 mov 0x204(%eax),%ebp 10: 0f b6 80 d9 07 00 00 movzbl 0x7d9(%eax),%eax 17: 8b 3c 95 f4 dc 15 f9 mov -0x6ea230c(,%edx,4),%edi 1e: 8b 14 95 d8 dc 15 f9 mov -0x6ea2328(,%edx,4),%edx 25: 83 c0 80 add $0xffffff80,%eax 28: 89 14 24 mov %edx,(%esp) 2b: 0f b6 37 ...

This breaks with: make ARCH=x86 x86_64_defconfig cp .config arch/x86/configs/x86_64_defconfig make ARCH=x86 i386_defconfig make ARCH=x86 x86_64_defconfig cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed --

Ok, tested current -git and I was able to connect to the encrypted network. So, I'm happy :-) ! And 2.6.27 has even fixed a regression I was having with 2.6.{25,26}. Justin Madru --

The problem is triggered by the following section: if (priv->fw_var >= 0x300) { /* Firmware supports QoS, use it! */ priv->tx_stats[0].limit = 3; priv->tx_stats[1].limit = 4; priv->tx_stats[2].limit = 3; priv->tx_stats[3].limit = 1; dev->queues = 4; } If fw_var is less than 0x300, then the bug does not trigger. On my system, if I change the number of queues to 1, then ...

Much the same as usual; perhaps a bit lower. 16/CPU would probably be ample. But given that the kernel also needs to be able to boot native properly, just choosing the normal number would be best. I long for the day it becomes dynamic... J --

On Sat, Aug 2, 2008 at 10:26 PM, Eric W. Biederman what should xen pv 64 get for NR_IRQS? YH --

Xen pv 64 will work at least as well with a larger definition for NR_IRQS as it will work with a smaller definition, and since NR_VECTORS is 256 we always have more irqs with the 32bit definition we were mistakenly using. Xen has 1024 event channels so I expect 1024 would the nice number to provide there. Eric --

"the latest mainline" ... I guess that means the same as what I termed "Linus's latest git version" ? -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.940.382.4214 --

If Windows is returning true for all ever existing OSI(Windows XY) versions as Linux is doing it and they stick to that in the future, then my above assumption is not true. If the next Windows version also returns true for the one for which the workaround applies to, they have to take care that only the one OS is matching in a follow up update, e.g.: And(brokenOS, !new_OSes) So this should make half way sure that vendors do not mis-use this too often. Also it is ensured that the next ...

You are assuming bad RAM then not bad bus loadings, corrosion on the If you have a good enough pile of hardware and the right monitoring stuff loaded then you should get EDAC event logs from the PCI/PCI-X for PCI card logged traps, MCE errors for the higher level busses, L1/L2 cache or CPU parity errors and ECC traps for memory problems either via EDAC or MCE. Yes for SCSI. In theory yes for ATA but I've never tested to see what the For the simpler cases perhaps. The more interesting ...

git-am -k ... FWIW, I tend to leave [patch...] alone; the second one slipped unnoticed - usually I edit ones like that, including the subject. --

Hi Keith, You may just have identified a scaling problem here. I see no difference to many thousand TCP/IP connections in your description. What actions on many thousand fds are supported poorly or not at all? Are you only concerned about the memory requirements? Please elaborate or point me to a place where you did already :-) Best Regards Ingo Oeser --

>>>>> "Keith" == Keith Packard <keithp@keithp.com> writes: Keith> I can't create that many files; I need thousands of them. Why? If you need thousands of files, won't the overhead of managing them dynamically start to be a big load as well? I assume (sorry for not looking at the code in depth) that you're trying to setup specific regions of memory with various attributes for the DRI/DRM/GEM/TTF access to Video cards? Just seeing your statement that you wanted to add ioctls made ...

On Fri, 1 Aug 2008 15:20:30 +1000 Stephen Rothwell <sfr@canb.auug.org.au> w= ^^^ Freudian slip :-) --=20 Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/

Yes, that check isn't very well anchored. I've tightened that up in the latest version. Could you check your patch with the latest testing version for me: http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing -apw --

From: Mariusz Kozlowski <m.kozlowski@tuxland.pl> Thenk for the report and sample patch. I've decided to put the preemption disabled call at the smp_tsb_sync() call site so that smp_tsb_sync() can still invoke smp_call_function_mask() as a tail-call. Thanks again! sparc64: Need to disable preemption around smp_tsb_sync(). Based upon a bug report by Mariusz Kozlowski It uses smp_call_function_masked() now, which has a preemption-disabled requirement. Signed-off-by: David S. Miller ...

No. I applied your incremental fix and tested it for some time. It doesn't oops anymore in any way in spite of my best efforts :) Tested-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl> Thanks, --

OK, so I'll take Stephen's patch (thanks!) and send it to Linus. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds --

Hi Dominik, On Tue, 29 Jul 2008 16:45:58 +0200 Dominik Brodowski <linux@dominikbrodowsk= Yeah, I would say it is, now. (Notice how I cleverly delayed it for a week :-)) --=20 Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/

I believe down_trylock() came first. spin_trylock() was then the one that was gratuitously different and mutex_trylock() decided to follow the spinning semantics rather than the sleeping semantics. But yeah, whatever, big mess. I'm not convinced down_try() is an improvement. But I bet we could have got rid of most of the users of down_trylock() in the time that's been spent wanking about down_try(). Hey, let's make it return bool! Hey, let's argue about the name! Hey, let's ...

Btw, "dealing with it" can just be "don't bother". Leaving old stuff _alone_ is a perfectly good approach. Being slightly ugly for historical reasons is much less of a problem than just "change for change's sake". Linus --

I did: mkdir arch/m68k/include mv include/asm-m68k arch/m68k/include/asm and m68k still builds fine (I applied Stephen's patch for the asm-sparc inclusion problem for Sun 3/3x first, of course). As (a) I'm not using git (yet) for merging with Linus, and (b) this will cause some breakage in the m68knommu tree anyway, perhaps it's easiest if Greg takes care of it in m68knommu.git? Greg, is that OK for you? You can add my Acked-by: Geert Uytterhoeven ...

We'll have to query the controller vendors too and I think it's highly likely to cause problems on many controllers. -- tejun --

On Sat, 2 Aug 2008 19:49:22 -0400 (EDT), I waved a wand and this This is the one that I applied: Index: usb-2.6/drivers/usb/storage/transport.c =================================================================== --- usb-2.6.orig/drivers/usb/storage/transport.c +++ usb-2.6/drivers/usb/storage/transport.c @@ -663,7 +663,7 @@ void usb_stor_invoke_transport(struct sc } /* Did we transfer less than the minimum amount required? */ - if (srb->result == SAM_STAT_GOOD && + if ((srb->result == ...

On Sunday 03 August 2008, Borislav Petkov wrote: Some time ago we've changed the default from probing all ports to probe only safe ones (we had to do it because probing all ports may break other ISA devices) so there may be very unlikely cases when this bugfix caused regression and we would like people to be able to deduce the workaround from just reading kernel messages. --

From: Borislav Petkov <petkovbb@gmail.com> Date: Sun, 3 Aug 2008 09:28:53 +0200 Subject: [PATCH 2/2] ide-generic: handle probing of legacy io-ports Avoid probing the io-ports in case an IDE PCI controller is present and it uses the legacy iobases. If we still want to enforce the probing, we do ide_generic.probe_mask=0x3f on the kernel command line. Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-generic.c | 23 ++++++++++++++++++----- 1 files changed, 18 ...

crap, forget what i said here ^ :(. -- Regards/Gruss, Boris. --

On Sun, Aug 03, 2008 at 04:11:10PM +0200, Bartlomiej Zolnierkiewicz wrote: Issues addressed. Here's v2: --- From: Borislav Petkov <petkovbb@gmail.com> Date: Sun, 3 Aug 2008 09:28:53 +0200 Subject: [PATCH] ide-generic: handle probing of legacy io-ports v2 Avoid probing the io-ports in case an IDE PCI controller is present and it uses the legacy iobases. If we still want to enforce the probing, we do ide_generic.probe_mask=0x3f on the kernel command line. Signed-off-by: Borislav ...

On Sun, 3 Aug 2008 09:37:56 +0200 Please don't stuff large important pieces of code in header files where they will be overlooked NAK this. I'm happy to have a shared library directory for ATA stuff, containing useful C code, but hiding stuff in headers like that is just plain wrong. --

What do you mean by "overlooked"? If you're looking for the function defintion, any sensible code indexing tool will point you to the right place. And linux/ata.h already contains several c one liners/helpers. What is the difference between the two new functions and the ones already present there? Although the solution i propose is not adhering to some header/c file conventions, it is still the best one considering the other possibilities: a) code duplication: dumb idea, bloated kernel for ...

People expect code in C files, so in headers it gets missed as well as If you are going to #include two copies you might as well just copy it. Alan --

Hi Oliver sorry for the delay, I was out travelling with no access to CM109 hardware.. I recompiled the latest kernel from input-branch with CONFIG_USB_DEBUG enabled, the version reported is 2.6.27-rc1. Below you can see the syslog and the context of events: ;;; ;;; Insert CM109 device here: ;;; Aug 3 23:42:49 io kernel: usb usb1: usb resume Aug 3 23:42:49 io kernel: usb usb1: wakeup_rh Aug 3 23:42:49 io kernel: hub 1-0:1.0: hub_resume Aug 3 23:42:49 io kernel: uhci_hcd ...

Acked-by: "Theodore Ts'o" <tytso@mit.edu> - Ted --

Hi Matthew, No, you don't have to. I haven't merged that patch nor do I intend to do so until the regressions are fixed. And yes, I'm still waiting to hear from you how we're now doing with higher order page allocations... Pekka --

Making them symlinks is asking for trouble because some code does go around using stat and the like and tools like MAKEDEV have definite ideas. For /dev/tty the definition is precisely that it is your controlling tty. No reference to namespace and a task whose controlling tty is in a different namespace should still open the controlling tty not some parallel in another universe when you open /dev/tty. If you want to make sure the controlling tty is in the right namespace that can be done in ...

Alan Cox [alan@lxorguk.ukuu.org.uk] wrote: | > > 1. /dev/ptmx would have to change to a symlink, ptmx -> pts/ptmx. | > | > IIRC, /dev/tty also needs a similar symlink. | | Making them symlinks is asking for trouble because some code does go | around using stat and the like and tools like MAKEDEV have definite ideas. | | For /dev/tty the definition is precisely that it is your controlling | tty. No reference to namespace and a task whose controlling tty is in a | different namespace should ...

Sorry, I thought we were going with a complete device namespace - since that would address other devices as well and would avoid the following user-space issue. I guess this issue came up in OLS recently and have been looking into this again. I have some helper patches to explore multiple mounts of devpts Sukadev --