Re: [PATCH] net: Add missing extra2 parameter for ip_default_ttl sysctl

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Sunday, August 3, 2008 - 2:07 pm

From: Sven Wegener <sven.wegener@stealer.net>
Date: Sun, 3 Aug 2008 22:18:59 +0200 (CEST)


Applied, thanks a lot.

Please provide commit header line text when referencing SHA IDs,
as the SHA IDs can change when patches are applied to different
trees.  Here is the actual changelog message I used so you can
see what I mean:

    net: Add missing extra2 parameter for ip_default_ttl sysctl
    
    Commit 76e6ebfb40a2455c18234dcb0f9df37533215461 ("netns: add namespace
    parameter to rt_cache_flush") acceses the extra2 parameter of the
    ip_default_ttl ctl_table, but it is never set to a meaningful
    value. When e84f84f276473dcc673f360e8ff3203148bdf0e2 ("netns: place
    rt_genid into struct net") is applied, we'll oops in
    rt_cache_invalidate(). Set extra2 to init_net, to avoid that.
    
    Reported-by: Marcin Slusarz <marcin.slusarz@gmail.com>
    Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
    Tested-by: Marcin Slusarz <marcin.slusarz@gmail.com>
    Acked-by: Denis V. Lunev <den@openvz.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
oops in rt_cache_invalidate (2.6.27-rc1-2b12a4c), Marcin Slusarz, (Sun Aug 3, 10:02 am)
Re: oops in rt_cache_invalidate (2.6.27-rc1-2b12a4c), Denis V. Lunev, (Sun Aug 3, 11:56 am)
Re: oops in rt_cache_invalidate (2.6.27-rc1-2b12a4c), Sven Wegener, (Sun Aug 3, 12:24 pm)
Re: oops in rt_cache_invalidate (2.6.27-rc1-2b12a4c), Sven Wegener, (Sun Aug 3, 12:43 pm)
Re: oops in rt_cache_invalidate (2.6.27-rc1-2b12a4c), Sven Wegener, (Sun Aug 3, 12:48 pm)
Re: oops in rt_cache_invalidate (2.6.27-rc1-2b12a4c), Marcin Slusarz, (Sun Aug 3, 12:52 pm)
Re: oops in rt_cache_invalidate (2.6.27-rc1-2b12a4c), Denis V. Lunev, (Sun Aug 3, 1:04 pm)
Re: [PATCH] net: Add missing extra2 parameter for ip_defau ..., David Miller, (Sun Aug 3, 2:07 pm)