Re: kbuild now support arch/$ARCH/include - time for ARCHs to convert

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Geert Uytterhoeven
Date: Sunday, August 3, 2008 - 1:16 pm

On Fri, 1 Aug 2008, Greg Ungerer wrote:

I did:

    mkdir arch/m68k/include
    mv include/asm-m68k arch/m68k/include/asm

and m68k still builds fine (I applied Stephen's patch for the
asm-sparc inclusion problem for Sun 3/3x first, of course).

As (a) I'm not using git (yet) for merging with Linus, and (b) this will
cause some breakage in the m68knommu tree anyway, perhaps it's easiest if Greg
takes care of it in m68knommu.git?

Greg, is that OK for you?
You can add my Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

There seem to be 3 classes of m68knommu header files:
  1. Plain files (some of them may be (nearly) identical copies of the
     m68k variants,
  2. Files that just include the m68k variant,
  3. Files that include the m68k variant and do something more (pci.h and
     setup.h).

Since I don't think we want to do the m68k/m68knommu merge right now
(Sorry Arnd, I'll keep your script in mind anyway!), the simplest way is to:
  - Remove all files from class 2, and add to the Makefile:

	ccflags-y += -Iarch/m68k/include

  - Include verbatim the contents of the m68k variant for class 3, cfr.
    Stephen patch for the asm-sparc inclusion problem for Sun 3/3x).

Do you agree?

Thanks!

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: kbuild now support arch/$ARCH/include - time for ARCHs ..., Geert Uytterhoeven, (Wed Jul 30, 5:26 am)
Re: kbuild now support arch/$ARCH/include - time for ARCHs ..., Geert Uytterhoeven, (Thu Jul 31, 12:17 am)
Re: kbuild now support arch/$ARCH/include - time for ARCHs ..., Martin Schwidefsky, (Fri Aug 1, 1:35 am)
Re: kbuild now support arch/$ARCH/include - time for ARCHs ..., Geert Uytterhoeven, (Sun Aug 3, 1:16 pm)
Re: kbuild now support arch/$ARCH/include - time for ARCHs ..., Geert Uytterhoeven, (Mon Aug 4, 9:00 am)
Re: kbuild now support arch/$ARCH/include - time for ARCHs ..., Geert Uytterhoeven, (Tue Aug 5, 10:16 am)