Re: [PATCH 00/25] dyn_array and nr_irqs support v3

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Yinghai Lu <yhlu.kernel@...>

Cc: Ingo Molnar <mingo@...>, Thomas Gleixner <tglx@...>, H. Peter Anvin <hpa@...>, Dhaval Giani <dhaval@...>, Mike Travis <travis@...>, Andrew Morton <akpm@...>, <linux-kernel@...>

Subject: Re: [PATCH 00/25] dyn_array and nr_irqs support v3

Date: Sunday, August 3, 2008 - 1:51 am

It appears that quite a few of the places you have changed are testing
to see if an irq is valid.  The idiomatic way to perform that test in
the kernel is:

if (irq)

With no test to see if you are >= NR_IRQS.

I expect that is the change we want in the drivers that are performing such a silly
extra check.

Eric


--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 00/25] dyn_array and nr_irqs support v3, Yinghai Lu, (Sat Aug 2, 10:59 pm)

Re: [PATCH 00/25] dyn_array and nr_irqs support v3, H. Peter Anvin, (Tue Aug 5, 7:01 pm)

Re: [PATCH 00/25] dyn_array and nr_irqs support v3, Yinghai Lu, (Tue Aug 5, 7:15 pm)

Re: [PATCH 00/25] dyn_array and nr_irqs support v3, H. Peter Anvin, (Tue Aug 5, 7:26 pm)

Re: [PATCH 00/25] dyn_array and nr_irqs support v3, Yinghai Lu, (Tue Aug 5, 7:53 pm)

Re: [PATCH 00/25] dyn_array and nr_irqs support v3, Eric W. Biederman, (Sun Aug 3, 1:51 am)

Re: [PATCH 00/25] dyn_array and nr_irqs support v3, Yinghai Lu, (Sun Aug 3, 2:04 am)

Re: [PATCH 00/25] dyn_array and nr_irqs support v3, Eric W. Biederman, (Sun Aug 3, 2:39 am)

Re: [PATCH 00/25] dyn_array and nr_irqs support v3, Mike Travis, (Mon Aug 4, 10:31 am)

Re: [PATCH 00/25] dyn_array and nr_irqs support v3, Yinghai Lu, (Sun Aug 3, 4:25 am)

Re: [PATCH 00/25] dyn_array and nr_irqs support v3, Eric W. Biederman, (Sun Aug 3, 5:15 am)

Re: [PATCH 00/25] dyn_array and nr_irqs support v3, Yinghai Lu, (Sun Aug 3, 1:54 pm)

Re: [PATCH 00/25] dyn_array and nr_irqs support v3, Yinghai Lu, (Sun Aug 3, 3:20 pm)

Re: [PATCH 00/25] dyn_array and nr_irqs support v3, Yinghai Lu, (Sun Aug 3, 9:59 pm)

[PATCH 01/25] x86: 64bit support more than 256 irq v2, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 02/25] x86: remove irq_vectors_limits, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 03/25] add dyn_array support, Yinghai Lu, (Sat Aug 2, 10:59 pm)

Re: [PATCH 03/25] add dyn_array support, Johannes Weiner, (Sun Aug 3, 12:03 am)

Re: [PATCH 03/25] add dyn_array support, Yinghai Lu, (Sun Aug 3, 12:21 am)

Re: [PATCH 03/25] add dyn_array support, Johannes Weiner, (Sun Aug 3, 12:55 am)

Re: [PATCH 03/25] add dyn_array support, Yinghai Lu, (Sun Aug 3, 1:04 am)

Re: [PATCH 03/25] add dyn_array support, Johannes Weiner, (Sun Aug 3, 1:31 am)

Re: [PATCH 03/25] add dyn_array support, Yinghai Lu, (Sun Aug 3, 1:39 am)

Re: [PATCH 03/25] add dyn_array support, Johannes Weiner, (Sun Aug 3, 1:47 am)

Re: [PATCH 03/25] add dyn_array support, Yinghai Lu, (Sun Aug 3, 1:48 am)

Re: [PATCH 03/25] add dyn_array support, Yinghai Lu, (Sun Aug 3, 1:40 am)

[PATCH 04/25] add per_cpu_dyn_array support, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 05/25] x86: alloc dyn_array all alltogether, Yinghai Lu, (Sat Aug 2, 10:59 pm)

Re: [PATCH 05/25] x86: alloc dyn_array all alltogether, Johannes Weiner, (Sun Aug 3, 12:16 am)

[PATCH 06/25] x86: enable dyn_array support, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 07/25] introduce nr_irqs, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 08/25] x86: using nr_irqs, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 09/25] drivers/char to use nr_irqs, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 10/25] drivers/net to use nr_irqs, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 11/25] drivers intr remapping to use nr_irqs, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 12/25] drivers/pcmcia to use nr_irqs, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 13/25] drivers/rtc to use nr_irqs, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 14/25] drivers/scsi to use nr_irqs, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 15/25] drivers/serial to use nr_irqs, Yinghai Lu, (Sat Aug 2, 10:59 pm)

Re: [PATCH 15/25] drivers/serial to use nr_irqs, Alan Cox, (Sun Aug 3, 9:02 am)

Re: [PATCH 15/25] drivers/serial to use nr_irqs, Yinghai Lu, (Sun Aug 3, 1:43 pm)

[PATCH 16/25] drivers proc to use nr_irqs, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 17/25] drivers xen events to use nr_irqs, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 18/25] make irq_timer_state to use dyn_array, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 19/25] make irq2_iommu to use dyn_array, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 20/25] make irq_desc to use dyn_array, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 21/25] serial: change remove NR_IRQS in 8250.c v2, Yinghai Lu, (Sat Aug 2, 10:59 pm)

Re: [PATCH 21/25] serial: change remove NR_IRQS in 8250.c v2, Alan Cox, (Sun Aug 3, 11:14 am)

Re: [PATCH 21/25] serial: change remove NR_IRQS in 8250.c v2, Eric W. Biederman, (Sun Aug 3, 3:57 pm)

Re: [PATCH 21/25] serial: change remove NR_IRQS in 8250.c v2, Alan Cox, (Mon Aug 4, 10:17 am)

Re: [PATCH 21/25] serial: change remove NR_IRQS in 8250.c v2, Eric W. Biederman, (Mon Aug 4, 2:51 pm)

[PATCH] serial: Remove NR_IRQS usage, Alan Cox, (Wed Aug 6, 9:09 am)

Re: [PATCH] serial: Remove NR_IRQS usage, Eric W. Biederman, (Wed Aug 6, 12:10 pm)

Re: [PATCH 21/25] serial: change remove NR_IRQS in 8250.c v2, Yinghai Lu, (Mon Aug 4, 2:13 pm)

Re: [PATCH 21/25] serial: change remove NR_IRQS in 8250.c v2, Alan Cox, (Sun Aug 3, 9:03 am)

[PATCH 22/25] irq: make irqs in kernel stat use per_cpu_dyn_..., Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 23/25] x86: use dyn_array in io_apic_xx.c, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 24/25] x86: get mp_irqs from madt, Yinghai Lu, (Sat Aug 2, 10:59 pm)

[PATCH 25/25] x86: remove nr_irq_vectors, Yinghai Lu, (Sat Aug 2, 10:59 pm)

Navigation

Popular discussions


linux-kernel:
Al Boldi	Re: [ck] Re: [ANNOUNCE] RSDL completely fair starvation free interactive cpu sched...
Ingo Molnar	Re: [patch] sched_clock(): cleanups
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Amit K. Arora	[RFC] Heads up on sys_fallocate()
git:

linux-netdev:
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Gerrit Renker	[PATCH 18/37] dccp: Support for Mandatory options
Denys Vlasenko	[PATCH 1/2] bnx2: factor out gzip unpacker
openbsd-misc:

Colocation donated by:

Online users

zeekec

Syndicate