Re: [PATCH] dyn_array: using %pF instead of print_fn_descriptor_symbol

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Yinghai Lu

Subject: Re: [PATCH] dyn_array: using %pF instead of print_fn_descriptor_symbol

Date: Friday, August 29, 2008 - 4:34 pm

On Fri, Aug 29, 2008 at 3:53 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
quoted text>>       ptr = __alloc_bootmem_nopanic(total_size, max_align, 0);
>>       if (!ptr)
>>               panic("Can not alloc dyn_alloc\n");

like to give exact error message.

quoted text>
> Why duplicate the panic()?  Just call __alloc_bootmem().
>
>> #ifdef CONFIF_GENERIC_HARDIRQS
>
> That doesn't appear to have been very well tested?

ah!
it should break sparc, m68k, and s390...

quoted text>
> The code has a few coding-style glitches which checkpatch can detect.
>

should only have 80 char length warning...

YH
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] dyn_array: using %pF instead of print_fn_descripto ..., Yinghai Lu, (Fri Aug 29, 3:07 pm)

Re: [PATCH] dyn_array: using %pF instead of print_fn_descr ..., Andrew Morton, (Fri Aug 29, 3:20 pm)

Re: [PATCH] dyn_array: using %pF instead of print_fn_descr ..., Yinghai Lu, (Fri Aug 29, 3:32 pm)

Re: [PATCH] dyn_array: using %pF instead of print_fn_descr ..., Andrew Morton, (Fri Aug 29, 3:45 pm)

Re: [PATCH] dyn_array: using %pF instead of print_fn_descr ..., Andrew Morton, (Fri Aug 29, 3:53 pm)

Re: [PATCH] dyn_array: using %pF instead of print_fn_descr ..., Yinghai Lu, (Fri Aug 29, 4:34 pm)

Re: [PATCH] dyn_array: using %pF instead of print_fn_descr ..., Andrew Morton, (Fri Aug 29, 5:23 pm)

Re: [PATCH] dyn_array: using %pF instead of print_fn_descr ..., Ingo Molnar, (Sat Sep 6, 10:09 am)

Re: [PATCH] dyn_array: using %pF instead of print_fn_descr ..., Yinghai Lu, (Sat Sep 6, 10:16 am)

Re: [PATCH] dyn_array: using %pF instead of print_fn_descr ..., Ingo Molnar, (Sat Sep 6, 10:18 am)

Re: [PATCH] dyn_array: using %pF instead of print_fn_descr ..., Yinghai Lu, (Sat Sep 6, 10:27 am)


linux-kernel:
Greg Kroah-Hartman	[PATCH 041/196] kobject: add kobject_init_and_add function
Lukas Hejtmanek	Re: Another libata error related to OCZ SSD
Greg Kroah-Hartman	[PATCH 023/196] MCP_UCB1200: Convert from class_device to device
Florian Fainelli	Re: System clock runs too fast after 2.6.27 -> 2.6.28.1 upgrade
Christoph Lameter	[patch 1/4] mmu_notifier: Core code
git:
Johannes Schindelin	Re: [PATCH 1/2] Add strbuf_initf()
John Bito	[EGIT] Push to GitHub caused corruption
Jakub Narebski	Re: [PATCH 0/2] gitweb: patch view
Junio C Hamano	Re: [PATCH] When a remote is added but not fetched, tell the user.
Andy Parkins	Re: [RFC] Submodules in GIT
git-commits-head:
Linux Kernel Mailing List	ahci: Workaround HW bug for SB600/700 SATA controller PMP support
Linux Kernel Mailing List	V4L/DVB (11086): au0828: rename macro for currently non-function VBI support
Linux Kernel Mailing List	ceph: client types
Linux Kernel Mailing List	ceph: on-wire types
Linux Kernel Mailing List	crypto: chainiv - Use kcrypto_wq instead of keventd_wq
linux-netdev:
Andrew Morton	Re: [Bugme-new] [Bug 14969] New: b44: WOL does not work in suspended state
Giuseppe CAVALLARO	Re: [PATCH 03/13] stmmac: add the new Header file for stmmac platform data
Taku Izumi	[PATCH 3/3] ixgbe: add registers etc. printout code just before resetting adapters
Eric Dumazet	rps: some comments
Thomas Gleixner	Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:
openbsd-misc:
Stephan Andreas	problems with login after xlock in OpenBSD release 4.7
pmc	Make A Change. Alcoholism and Drug Addiction Treatment
ropers	Re: what exactly is enc0?
Fuad NAHDI	Re: What does your environment look like?
Matthew Szudzik	Typo on OpenBSD 4.4 CD Set