Home » Mailing list archives » linux-kernel » 2008 » August » 29

Re: [PATCH] make might_sleep() display the oopsing process

Previous thread: [PATCH] shrink printk timestamp field by Joe Korty on Wednesday, August 27, 2008 - 8:17 am. (9 messages)

Next thread: [PATCH -V3 01/11] percpu_counters: make fbc->count read atomic on 32 bit architecture by Aneesh Kumar K.V on Wednesday, August 27, 2008 - 8:28 am. (11 messages)
[view original message]
From: Joe Korty
Subject: [PATCH] make might_sleep() display the oopsing process
Date: Wednesday, August 27, 2008 - 8:21 am

Expand might_sleep's printk to indicate the oopsing process.

Signed-off-by: Joe Korty <joe.korty@ccur.com>

Index: 2.6.27-rc4-git4/kernel/sched.c
===================================================================
--- 2.6.27-rc4-git4.orig/kernel/sched.c	2008-08-26 17:44:34.000000000 -0400
+++ 2.6.27-rc4-git4/kernel/sched.c	2008-08-26 18:24:08.000000000 -0400
@@ -8183,8 +8183,8 @@
 		prev_jiffy = jiffies;
 		printk(KERN_ERR "BUG: sleeping function called from invalid"
 				" context at %s:%d\n", file, line);
-		printk("in_atomic():%d, irqs_disabled():%d\n",
-			in_atomic(), irqs_disabled());
+		printk("in_atomic():%d, irqs_disabled():%d, pid: %d, name: %s\n",
+			in_atomic(), irqs_disabled(), current->pid, current->comm);
 		debug_show_held_locks(current);
 		if (irqs_disabled())
 			print_irqtrace_events(current);
--


[ message continues ]
[view original message]
From: Ingo Molnar
Subject: Re: [PATCH] make might_sleep() display the oopsing process
Date: Thursday, August 28, 2008 - 2:36 am

good idea - applied to tip/sched/devel - thanks Joe.

	Ingo
--


[ message continues ]
[view original message]
From: Andrew Morton
Subject: Re: [PATCH] make might_sleep() display the oopsing process
Date: Friday, August 29, 2008 - 4:20 pm

On Thu, 28 Aug 2008 11:36:28 +0200

Why?  I don't recall ever having been interested in this information.

(I shouldn't have to ask questions like this.  Please spend a little
more time in preparing the patch descriptions).

--


[ message continues ]
[view original message]
From: Joe Korty
Subject: Re: [PATCH] make might_sleep() display the oopsing process
Date: Saturday, August 30, 2008 - 7:45 am

I wrote and used the patch once, as I wanted to know
which program in a lengthy multiple-program test suite
was triggering the problem.  That made it easier coming
up with a shortened test that would replicate the problem.

However I only needed it that one time so this patch can
be considered to be exceptionally optional :)

Joe



--


[ message continues ]
[view original message]
From: Arjan van de Ven
Subject: Re: [PATCH] make might_sleep() display the oopsing process
Date: Saturday, August 30, 2008 - 9:04 am

On Sat, 30 Aug 2008 10:45:20 -0400

WARN() and WARN_ON() already print the oopsing process.
so if might_sleep() just calls one of those it already prints it.
If it doesn't call one of these.. maybe it should?


-- 
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--


[ message continues ]
Previous thread: [PATCH] shrink printk timestamp field by Joe Korty on Wednesday, August 27, 2008 - 8:17 am. (9 messages)

Next thread: [PATCH -V3 01/11] percpu_counters: make fbc->count read atomic on 32 bit architecture by Aneesh Kumar K.V on Wednesday, August 27, 2008 - 8:28 am. (11 messages)