Home » Mailing list archives » linux-kernel » 2008 » August » 29

Re: [PATCH] dyn_array: using %pF instead of print_fn_descriptor_symbol

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andrew Morton <akpm@...>
To: Yinghai Lu <yhlu.kernel@...>
Cc: <mingo@...>, <linux-kernel@...>
Subject: Re: [PATCH] dyn_array: using %pF instead of print_fn_descriptor_symbol
Date: Friday, August 29, 2008 - 6:53 pm

>	ptr = __alloc_bootmem_nopanic(total_size, max_align, 0);


Why duplicate the panic()?  Just call __alloc_bootmem().


> #ifdef CONFIF_GENERIC_HARDIRQS


That doesn't appear to have been very well tested?


The code has a few coding-style glitches which checkpatch can detect.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] dyn_array: using %pF instead of print_fn_descriptor_..., Yinghai Lu, (Fri Aug 29, 6:07 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Andrew Morton, (Fri Aug 29, 6:20 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Yinghai Lu, (Fri Aug 29, 6:32 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Andrew Morton, (Fri Aug 29, 6:53 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Ingo Molnar, (Sat Sep 6, 1:09 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Yinghai Lu, (Sat Sep 6, 1:16 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Ingo Molnar, (Sat Sep 6, 1:18 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Yinghai Lu, (Sat Sep 6, 1:27 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Yinghai Lu, (Fri Aug 29, 7:34 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Andrew Morton, (Fri Aug 29, 8:23 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Andrew Morton, (Fri Aug 29, 6:45 pm)