login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
August
»
29
Re: [PATCH] dyn_array: using %pF instead of print_fn_descriptor_symbol
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Andrew Morton <akpm@...>
To: Yinghai Lu <yhlu.kernel@...>
Cc: <mingo@...>, <linux-kernel@...>
Subject:
Re: [PATCH] dyn_array: using %pF instead of print_fn_descriptor_symbol
Date: Friday, August 29, 2008 - 6:45 pm
On Fri, 29 Aug 2008 15:32:58 -0700 "Yinghai Lu" <yhlu.kernel@gmail.com> wrote:
quoted text
> On Fri, Aug 29, 2008 at 3:20 PM, Andrew Morton > <akpm@linux-foundation.org> wrote: > > On Fri, 29 Aug 2008 15:07:49 -0700 > > Yinghai Lu <yhlu.kernel@gmail.com> wrote: > > > >> + printk(KERN_DEBUG "per_cpu_dyn_array %pF ==> [%#lx - %#lx]\n", > >> + da->name, phys, phys + size); > > > > This: > > > > struct dyn_array { > > void **name; > > > > is a bit confusing. One normally expects a variable called "name" to > > point at a character string. > > > > What _does_ this thing point at? There are no code comments which I > > can find, it's unobvious from the source code, the type is the > > information-free void** and the identifier is misleading. > > > > I find that documenting the data structures is the best way of making > > code understandable (and hence maintainable). > > struct dyn_array { > void **name; > unsigned long size; > unsigned int *nr; > unsigned long align; > void (*init_work)(void *); > }; > extern struct dyn_array *__dyn_array_start[], *__dyn_array_end[]; > extern struct dyn_array *__per_cpu_dyn_array_start[], > *__per_cpu_dyn_array_end[]; > > #define DEFINE_DYN_ARRAY_ADDR(nameX, addrX, sizeX, nrX, alignX, init_workX) \ > static struct dyn_array __dyn_array_##nameX __initdata = \ > { .name = (void **)&(nameX),\ > .size = sizeX,\ > .nr = &(nrX),\ > .align = alignX,\ > .init_work = init_workX,\ > }; \ > static struct dyn_array *__dyn_array_ptr_##nameX __used \ > __attribute__((__section__(".dyn_array.init"))) = \ > &__dyn_array_##nameX > > #define DEFINE_DYN_ARRAY(nameX, sizeX, nrX, alignX, init_workX) \ > DEFINE_DYN_ARRAY_ADDR(nameX, nameX, sizeX, nrX, alignX, init_workX) > > and use is > > struct irq_desc *sparse_irqs; > DEFINE_DYN_ARRAY(sparse_irqs, sizeof(struct irq_desc), nr_irq_desc, > PAGE_SIZE, init_work); > > > then sparse_irqs is pointer, and .name store the address of that pointer. > > later use > *da->name = phys_to_virt(phys); > to take back the dyn address. >
Well yes, I have a copy of that too. Why is it called "name"? --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] dyn_array: using %pF instead of print_fn_descriptor_...
, Yinghai Lu
, (Fri Aug 29, 6:07 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip...
, Andrew Morton
, (Fri Aug 29, 6:20 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip...
, Yinghai Lu
, (Fri Aug 29, 6:32 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip...
, Andrew Morton
, (Fri Aug 29, 6:53 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip...
, Ingo Molnar
, (Sat Sep 6, 1:09 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip...
, Yinghai Lu
, (Sat Sep 6, 1:16 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip...
, Ingo Molnar
, (Sat Sep 6, 1:18 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip...
, Yinghai Lu
, (Sat Sep 6, 1:27 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip...
, Yinghai Lu
, (Fri Aug 29, 7:34 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip...
, Andrew Morton
, (Fri Aug 29, 8:23 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip...
, Andrew Morton
, (Fri Aug 29, 6:45 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Al Boldi
Re: [ck] Re: [ANNOUNCE] RSDL completely fair starvation free interactive cpu sched...
Ingo Molnar
Re: [patch] sched_clock(): cleanups
Greg KH
[GIT PATCH] driver core patches against 2.6.24
Amit K. Arora
[RFC] Heads up on sys_fallocate()
git
:
linux-netdev
:
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller
[GIT]: Networking
Gerrit Renker
[PATCH 18/37] dccp: Support for Mandatory options
Denys Vlasenko
[PATCH 1/2] bnx2: factor out gzip unpacker
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
1 user
and
942 guests
online.
Online users
zeekec
Syndicate