Home » Mailing list archives » linux-kernel » 2008 » August » 29

Re: [PATCH] dyn_array: using %pF instead of print_fn_descriptor_symbol

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andrew Morton <akpm@...>
To: Yinghai Lu <yhlu.kernel@...>
Cc: <mingo@...>, <linux-kernel@...>, <yhlu.kernel@...>
Subject: Re: [PATCH] dyn_array: using %pF instead of print_fn_descriptor_symbol
Date: Friday, August 29, 2008 - 6:20 pm

On Fri, 29 Aug 2008 15:07:49 -0700

Yinghai Lu  wrote:


> +		printk(KERN_DEBUG "per_cpu_dyn_array %pF ==> [%#lx - %#lx]\n",


This:


struct dyn_array {

	void **name;


is a bit confusing.  One normally expects a variable called "name" to

point at a character string.


What _does_ this thing point at?  There are no code comments which I

can find, it's unobvious from the source code, the type is the

information-free void** and the identifier is misleading.


I find that documenting the data structures is the best way of making

code understandable (and hence maintainable).


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] dyn_array: using %pF instead of print_fn_descriptor_..., Yinghai Lu, (Fri Aug 29, 6:07 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Andrew Morton, (Fri Aug 29, 6:20 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Yinghai Lu, (Fri Aug 29, 6:32 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Andrew Morton, (Fri Aug 29, 6:53 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Ingo Molnar, (Sat Sep 6, 1:09 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Yinghai Lu, (Sat Sep 6, 1:16 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Ingo Molnar, (Sat Sep 6, 1:18 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Yinghai Lu, (Sat Sep 6, 1:27 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Yinghai Lu, (Fri Aug 29, 7:34 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Andrew Morton, (Fri Aug 29, 8:23 pm)
Re: [PATCH] dyn_array: using %pF instead of print_fn_descrip..., Andrew Morton, (Fri Aug 29, 6:45 pm)