Home » Mailing list archives » linux-kernel » 2008 » August » 29

Re: drivers/char/random.c line 728 BUG

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andrew Morton <akpm@...>
To: <aaron@...>, <mpm@...>, <linux-kernel@...>, <tytso@...>, <stable@...>
Subject: Re: drivers/char/random.c line 728 BUG
Date: Friday, August 29, 2008 - 3:54 pm

On Fri, 29 Aug 2008 12:48:07 -0700

Andrew Morton  wrote:


> We could fix this by moving the assertion inside the lock, but it seems


The fixed version even generates improved code.


Let's try to avoid repeats:


--- a/drivers/char/random.c~drivers-char-randomc-fix-a-race-which-can-lead-to-a-bogus-bug-fix

+++ a/drivers/char/random.c

@@ -407,7 +407,7 @@ struct entropy_store {

 	/* read-write data: */

 	spinlock_t lock;

 	unsigned add_ptr;

-	int entropy_count;

+	int entropy_count;	/* Must at no time exceed ->POOLBITS! */

 	int input_rotate;

 };


_


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
drivers/char/random.c line 728 BUG, Aaron Straus, (Tue Aug 26, 6:59 pm)
Re: drivers/char/random.c line 728 BUG, Aaron Straus, (Thu Aug 28, 6:59 pm)
Re: drivers/char/random.c line 728 BUG, Andrew Morton, (Fri Aug 29, 3:48 pm)
Re: drivers/char/random.c line 728 BUG, Matt Mackall, (Wed Sep 3, 2:18 pm)
Re: drivers/char/random.c line 728 BUG, Aaron Straus, (Wed Sep 3, 2:28 pm)
Re: drivers/char/random.c line 728 BUG, Matt Mackall, (Wed Sep 3, 6:12 pm)
Re: drivers/char/random.c line 728 BUG, Andrew Morton, (Wed Sep 3, 6:32 pm)
Re: drivers/char/random.c line 728 BUG, Matt Mackall, (Wed Sep 3, 6:51 pm)
Re: drivers/char/random.c line 728 BUG, Andrew Morton, (Wed Sep 3, 7:12 pm)
Re: drivers/char/random.c line 728 BUG, Aaron Straus, (Fri Aug 29, 6:31 pm)
Re: drivers/char/random.c line 728 BUG, Andrew Morton, (Fri Aug 29, 6:42 pm)
Re: drivers/char/random.c line 728 BUG, Andrew Morton, (Fri Aug 29, 3:54 pm)