Re: Cleanup and updates of x86 CPU definitions

Previous thread: [PATCH 4/4 2.6.28] cxgb3i - cxgb3i iscsi driver by Karen Xie on Wednesday, August 27, 2008 - 9:22 pm. (1 message)

Next thread: [PATCH -next] sysctl: simplify ->strategy by Alexey Dobriyan on Wednesday, August 27, 2008 - 10:02 pm. (1 message)
From: H. Peter Anvin
Date: Wednesday, August 27, 2008 - 9:30 pm

Hi all,

I have just committed to tip:x86/cpu the following patch series:

H. Peter Anvin (3):
       x86: generate names for /proc/cpuinfo from <asm/cpufeature.h>
       x86: cpufeature: add Intel features from CPUID and AVX specs
       x86: <asm/cpufeature.h>: clean up overlong lines, whitespace

The combined patch is below.

This changes the CPU feature naming code so that all that information 
comes from <asm-x86/cpufeature.h>.  In the past we have had a number of 
problems with cpufeature.h diverging from what /proc/cpuinfo showed (not 
to mention that at one point we would show different things for 32 and 
64 bits.)

I'm flagging this especially, since this is a patch fairly likely to 
conflict with other changes (incluing in other trees), although 
hopefully in a trivial fashion (this patchset should supercede) since I 
have gone through all the Intel and AMD documentation I could find and 
made sure it has the flags.

It is definitely unfortunate how the kernel sources and /proc/cpuinfo 
use different names for features; given that we can't change 
/proc/cpuinfo it might be worthwhile to run a sed script over the kernel 
sources.

	-hpa
From: Jeremy Fitzhardinge
Date: Thursday, August 28, 2008 - 1:11 pm

Is this supposed to appear as "Safer" in /proc/cpuinfo?  Or should this
be ``Safer''?

    J
--

From: H. Peter Anvin
Date: Thursday, August 28, 2008 - 1:22 pm

It was a dumb-ass thinko on my part (already fixed in tip:x86/cpu).

	-hpa
--

Previous thread: [PATCH 4/4 2.6.28] cxgb3i - cxgb3i iscsi driver by Karen Xie on Wednesday, August 27, 2008 - 9:22 pm. (1 message)

Next thread: [PATCH -next] sysctl: simplify ->strategy by Alexey Dobriyan on Wednesday, August 27, 2008 - 10:02 pm. (1 message)