On Thu, Aug 28, 2008 at 08:32:23PM +0200, Vegard Nossum wrote:

quoted text
> How do you feel about this patch? It's all about making kmemcheck more

> useful... and not much else. Does it have any chance of entering the

> kernel along with kmemcheck (when/if that happens)?

DEFINE_BITFIELD is horrible.
> @@ -285,11 +286,12 @@ struct sk_buff {

quoted text
>  		};

>  	};

>  	__u32			priority;

> -	__u8			local_df:1,

> +	DEFINE_BITFIELD(__u8,	flags1,

> +				local_df:1,

>  				cloned:1,

>  				ip_summed:2,

>  				nohdr:1,

> -				nfctinfo:3;

> +				nfctinfo:3);

>  	__u8			pkt_type:3,

>  				fclone:2,

>  				ipvs_property:1,

--

unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

the body of a message to majordomo@vger.kernel.org

More majordomo info at  http://vger.kernel.org/majordomo-info.html

Please read the FAQ at  http://www.tux.org/lkml/