[PATCH -next] sysctl: simplify ->strategy

Previous thread: Cleanup and updates of x86 CPU definitions by H. Peter Anvin on Wednesday, August 27, 2008 - 9:30 pm. (3 messages)

Next thread: [PATCH] coredump_filter: add hugepage core dumping by KOSAKI Motohiro on Wednesday, August 27, 2008 - 10:24 pm. (20 messages)
From: Alexey Dobriyan
Date: Wednesday, August 27, 2008 - 10:02 pm

name and nlen parameters passed to ->strategy hook are unused, remove them.
In general ->strategy hook should know what it's doing, and don't do
something tricky for which, say, pointer to original userspace array may
be needed (name).

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 arch/frv/kernel/pm.c           |    6 +++---
 arch/mips/lasat/sysctl.c       |   17 ++++++++---------
 drivers/char/random.c          |    2 +-
 include/linux/sysctl.h         |    2 +-
 include/net/ip.h               |    2 +-
 include/net/ndisc.h            |    5 ++---
 ipc/ipc_sysctl.c               |    9 ++++-----
 kernel/sysctl.c                |   29 +++++++++++++----------------
 kernel/utsname_sysctl.c        |    5 ++---
 net/decnet/dn_dev.c            |    4 ++--
 net/decnet/sysctl_net_decnet.c |    4 ++--
 net/ipv4/devinet.c             |    7 +++----
 net/ipv4/route.c               |    7 +------
 net/ipv4/sysctl_net_ipv4.c     |   18 +++++++++---------
 net/ipv6/addrconf.c            |    1 -
 net/ipv6/ndisc.c               |   11 ++++-------
 16 files changed, 56 insertions(+), 73 deletions(-)

--- a/arch/frv/kernel/pm.c
+++ b/arch/frv/kernel/pm.c
@@ -211,7 +211,7 @@ static int cmode_procctl(ctl_table *ctl, int write, struct file *filp,
 	return try_set_cmode(new_cmode)?:*lenp;
 }
 
-static int cmode_sysctl(ctl_table *table, int __user *name, int nlen,
+static int cmode_sysctl(ctl_table *table,
 			void __user *oldval, size_t __user *oldlenp,
 			void __user *newval, size_t newlen)
 {
@@ -314,7 +314,7 @@ static int p0_procctl(ctl_table *ctl, int write, struct file *filp,
 	return try_set_p0(new_p0)?:*lenp;
 }
 
-static int p0_sysctl(ctl_table *table, int __user *name, int nlen,
+static int p0_sysctl(ctl_table *table,
 		     void __user *oldval, size_t __user *oldlenp,
 		     void __user *newval, size_t newlen)
 {
@@ -358,7 +358,7 @@ static int cm_procctl(ctl_table *ctl, int write, struct file *filp,
 	return try_set_cm(new_cm)?:*lenp;
 }
 
-static int ...
Previous thread: Cleanup and updates of x86 CPU definitions by H. Peter Anvin on Wednesday, August 27, 2008 - 9:30 pm. (3 messages)

Next thread: [PATCH] coredump_filter: add hugepage core dumping by KOSAKI Motohiro on Wednesday, August 27, 2008 - 10:24 pm. (20 messages)