Home » Mailing list archives » linux-kernel » 2008 » August » 27

Re: [PATCH 1/2] utrace core

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Alexey Dobriyan
Subject: Re: [PATCH 1/2] utrace core
Date: Wednesday, August 27, 2008 - 1:04 pm

1. UTRACE_ATTACH_MATCH_DATA is not used.

2. s/utrace_attached_engine/utrace_engine/g

   Engine which is not attached is either just allocated or scheduled
   for freeing

3. get_utrace_lock() is funny.

   From name one should get valid struct utrace or -E depending only on
   task, why engine matters is a mystery.

4. subsys_initcall

   Just use module_init() or comment why it's needed.

5. Dummy in examiner -- not used (of course!)

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/2] utrace, Roland McGrath, (Tue Aug 26, 3:01 pm)
[PATCH 1/2] utrace core, Roland McGrath, (Tue Aug 26, 3:01 pm)
[PATCH 2/2] utrace: ptrace cooperation, Roland McGrath, (Tue Aug 26, 3:02 pm)
Re: [PATCH 0/2] utrace, Alexey Dobriyan, (Tue Aug 26, 3:34 pm)
Re: [PATCH 0/2] utrace, Christoph Hellwig, (Tue Aug 26, 3:39 pm)
Re: [PATCH 1/2] utrace core, Alexey Dobriyan, (Tue Aug 26, 3:55 pm)
Re: [PATCH 0/2] utrace, Frank Ch. Eigler, (Tue Aug 26, 5:17 pm)
Re: [PATCH 0/2] utrace, Peter Zijlstra, (Tue Aug 26, 7:03 pm)
Re: [PATCH 0/2] utrace, Christoph Hellwig, (Wed Aug 27, 6:54 am)
Re: [PATCH 0/2] utrace, Alexey Dobriyan, (Wed Aug 27, 8:34 am)
Re: [PATCH 0/2] utrace, Ananth N Mavinakayan ..., (Wed Aug 27, 9:40 am)
Re: [PATCH 0/2] utrace, Alexey Dobriyan, (Wed Aug 27, 11:50 am)
Re: [PATCH 1/2] utrace core, Alexey Dobriyan, (Wed Aug 27, 1:04 pm)
Re: [PATCH 1/2] utrace core, Alexey Dobriyan, (Wed Aug 27, 2:32 pm)
Re: [PATCH 1/2] utrace core, Alexey Dobriyan, (Wed Aug 27, 2:46 pm)
Re: [PATCH 1/2] utrace core, Alexey Dobriyan, (Wed Aug 27, 3:00 pm)
Re: [PATCH 0/2] utrace, Frank Ch. Eigler, (Fri Aug 29, 12:04 pm)
Re: [PATCH 2/2] utrace: ptrace cooperation, Christoph Hellwig, (Sat Aug 30, 6:38 am)
Re: [PATCH 0/2] utrace, Christoph Hellwig, (Sat Aug 30, 6:40 am)
Re: [PATCH 0/2] utrace, Christoph Hellwig, (Sat Aug 30, 6:43 am)
Re: [PATCH 1/2] utrace core, Christoph Hellwig, (Sat Aug 30, 6:45 am)
Re: [PATCH 1/2] utrace core, Alexey Dobriyan, (Sat Aug 30, 8:05 am)
Re: [PATCH 0/2] utrace, Roland McGrath, (Wed Sep 3, 5:09 am)
Re: [PATCH 2/2] utrace: ptrace cooperation, Roland McGrath, (Wed Sep 3, 5:10 am)
Re: [PATCH 1/2] utrace core, Roland McGrath, (Wed Sep 3, 5:11 am)
Re: [PATCH 1/2] utrace core, Roland McGrath, (Wed Sep 3, 5:11 am)
Re: [PATCH 1/2] utrace core, Petr Tesarik, (Wed Sep 3, 5:58 am)
Re: [PATCH 1/2] utrace core, Alexey Dobriyan, (Wed Sep 3, 10:01 am)
Re: [PATCH 1/2] utrace core, Roland McGrath, (Wed Sep 3, 11:08 am)
Re: [PATCH 0/2] utrace, Christoph Hellwig, (Wed Sep 3, 11:37 am)
Re: [PATCH 2/2] utrace: ptrace cooperation, Christoph Hellwig, (Wed Sep 3, 11:41 am)
Re: [PATCH 1/2] utrace core, Christoph Hellwig, (Wed Sep 3, 11:44 am)
Re: [PATCH 1/2] utrace core, Christoph Hellwig, (Wed Sep 3, 11:46 am)
Re: [PATCH 1/2] utrace core, Petr Tesarik, (Thu Sep 4, 2:03 am)
Re: [PATCH 0/2] utrace, Peter Zijlstra, (Mon Oct 6, 1:47 pm)