[PATCH 38/59] CRED: Wrap task credential accesses in the OCFS2 filesystem

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Howells
Date: Wednesday, August 27, 2008 - 6:48 am

Wrap access to task credentials so that they can be separated more easily from
the task_struct during the introduction of COW creds.

Change most current->(|e|s|fs)[ug]id to current_(|e|s|fs)[ug]id().

Change some task->e?[ug]id to task_e?[ug]id().  In some places it makes more
sense to use RCU directly rather than a convenient wrapper; these will be
addressed by later patches.

Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: James Morris <jmorris@namei.org>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <joel.becker@oracle.com>
Cc: ocfs2-devel@oss.oracle.com
---

 fs/ocfs2/dlm/dlmfs.c |    8 ++++----
 fs/ocfs2/namei.c     |    4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)


diff --git a/fs/ocfs2/dlm/dlmfs.c b/fs/ocfs2/dlm/dlmfs.c
index 533a789..3516d8a 100644
--- a/fs/ocfs2/dlm/dlmfs.c
+++ b/fs/ocfs2/dlm/dlmfs.c
@@ -339,8 +339,8 @@ static struct inode *dlmfs_get_root_inode(struct super_block *sb)
 		ip = DLMFS_I(inode);
 
 		inode->i_mode = mode;
-		inode->i_uid = current->fsuid;
-		inode->i_gid = current->fsgid;
+		inode->i_uid = current_fsuid();
+		inode->i_gid = current_fsgid();
 		inode->i_blocks = 0;
 		inode->i_mapping->backing_dev_info = &dlmfs_backing_dev_info;
 		inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
@@ -365,8 +365,8 @@ static struct inode *dlmfs_get_inode(struct inode *parent,
 		return NULL;
 
 	inode->i_mode = mode;
-	inode->i_uid = current->fsuid;
-	inode->i_gid = current->fsgid;
+	inode->i_uid = current_fsuid();
+	inode->i_gid = current_fsgid();
 	inode->i_blocks = 0;
 	inode->i_mapping->backing_dev_info = &dlmfs_backing_dev_info;
 	inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
index 76d1d13..ef14614 100644
--- a/fs/ocfs2/namei.c
+++ b/fs/ocfs2/namei.c
@@ -426,13 +426,13 @@ static int ocfs2_mknod_locked(struct ocfs2_super *osb,
 	fe->i_blkno = cpu_to_le64(fe_blkno);
 	fe->i_suballoc_bit = cpu_to_le16(suballoc_bit);
 	fe->i_suballoc_slot = cpu_to_le16(inode_ac->ac_alloc_slot);
-	fe->i_uid = cpu_to_le32(current->fsuid);
+	fe->i_uid = cpu_to_le32(current_fsuid());
 	if (dir->i_mode & S_ISGID) {
 		fe->i_gid = cpu_to_le32(dir->i_gid);
 		if (S_ISDIR(mode))
 			mode |= S_ISGID;
 	} else
-		fe->i_gid = cpu_to_le32(current->fsgid);
+		fe->i_gid = cpu_to_le32(current_fsgid());
 	fe->i_mode = cpu_to_le16(mode);
 	if (S_ISCHR(mode) || S_ISBLK(mode))
 		fe->id1.dev1.i_rdev = cpu_to_le64(huge_encode_dev(dev));

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 00/59] Introduce credentials, Alan Cox, (Wed Aug 27, 6:33 am)
[PATCH 00/59] Introduce credentials, David Howells, (Wed Aug 27, 6:45 am)
[PATCH 38/59] CRED: Wrap task credential accesses in the O ..., David Howells, (Wed Aug 27, 6:48 am)
Re: [PATCH 00/59] Introduce credentials, David Howells, (Wed Aug 27, 7:24 am)
Re: [PATCH 00/59] Introduce credentials, Alan Cox, (Wed Aug 27, 9:39 am)
Re: [PATCH 04/59] CRED: Wrap task credential accesses in t ..., Benjamin Herrenschmidt, (Wed Aug 27, 4:45 pm)
Re: [PATCH 00/59] Introduce credentials, David Howells, (Thu Aug 28, 2:19 am)
Re: [PATCH 00/59] Introduce credentials, Alan Cox, (Thu Aug 28, 2:45 am)
Re: [PATCH 14/59] CRED: Wrap task credential accesses in 9 ..., Eric Van Hensbergen, (Thu Aug 28, 10:59 am)
Re: [PATCH 00/59] Introduce credentials, Paul E. McKenney, (Thu Aug 28, 1:28 pm)
Re: [PATCH 11/59] CRED: Wrap task credential accesses in v ..., Mauro Carvalho Chehab, (Fri Aug 29, 3:32 pm)