[PATCH 08/59] CRED: Wrap task credential accesses in the tty driver

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Howells
Date: Wednesday, August 27, 2008 - 6:46 am

Wrap access to task credentials so that they can be separated more easily from
the task_struct during the introduction of COW creds.

Change most current->(|e|s|fs)[ug]id to current_(|e|s|fs)[ug]id().

Change some task->e?[ug]id to task_e?[ug]id().  In some places it makes more
sense to use RCU directly rather than a convenient wrapper; these will be
addressed by later patches.

Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: James Morris <jmorris@namei.org>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
---

 drivers/char/tty_audit.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)


diff --git a/drivers/char/tty_audit.c b/drivers/char/tty_audit.c
index 3582f43..570d337 100644
--- a/drivers/char/tty_audit.c
+++ b/drivers/char/tty_audit.c
@@ -86,10 +86,12 @@ static void tty_audit_buf_push(struct task_struct *tsk, uid_t loginuid,
 	ab = audit_log_start(NULL, GFP_KERNEL, AUDIT_TTY);
 	if (ab) {
 		char name[sizeof(tsk->comm)];
+		uid_t uid = task_uid(tsk);
 
 		audit_log_format(ab, "tty pid=%u uid=%u auid=%u ses=%u "
-				 "major=%d minor=%d comm=", tsk->pid, tsk->uid,
-				 loginuid, sessionid, buf->major, buf->minor);
+				 "major=%d minor=%d comm=",
+				 tsk->pid, uid, loginuid, sessionid,
+				 buf->major, buf->minor);
 		get_task_comm(name, tsk);
 		audit_log_untrustedstring(ab, name);
 		audit_log_format(ab, " data=");

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 00/59] Introduce credentials, Alan Cox, (Wed Aug 27, 6:33 am)
[PATCH 00/59] Introduce credentials, David Howells, (Wed Aug 27, 6:45 am)
[PATCH 08/59] CRED: Wrap task credential accesses in the t ..., David Howells, (Wed Aug 27, 6:46 am)
Re: [PATCH 00/59] Introduce credentials, David Howells, (Wed Aug 27, 7:24 am)
Re: [PATCH 00/59] Introduce credentials, Alan Cox, (Wed Aug 27, 9:39 am)
Re: [PATCH 04/59] CRED: Wrap task credential accesses in t ..., Benjamin Herrenschmidt, (Wed Aug 27, 4:45 pm)
Re: [PATCH 00/59] Introduce credentials, David Howells, (Thu Aug 28, 2:19 am)
Re: [PATCH 00/59] Introduce credentials, Alan Cox, (Thu Aug 28, 2:45 am)
Re: [PATCH 14/59] CRED: Wrap task credential accesses in 9 ..., Eric Van Hensbergen, (Thu Aug 28, 10:59 am)
Re: [PATCH 00/59] Introduce credentials, Paul E. McKenney, (Thu Aug 28, 1:28 pm)
Re: [PATCH 11/59] CRED: Wrap task credential accesses in v ..., Mauro Carvalho Chehab, (Fri Aug 29, 3:32 pm)