Re: pull request: wireless-2.6 2008-08-26

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Marcel Holtmann
Date: Wednesday, August 27, 2008 - 4:10 am

Hi Dave,


I did a quick review of the offending patch queue. And some of them
should go in since they are fixing real bugs (as far as I can tell from
a quick review). Others have to clearly wait for the next merge window.

Thomas, please go through the list of patches and pick the real bug
fixes. The cleanup patches can't go in since they are after the merge
window. And being one of the offenders why Dave got flamed by Linus,
there is no way to get these through. And my big offender was a
regression that broke userspace and came with a lengthy commit message.

Speaking of which, you better have a more convincing commit message if
you wanna get something in after the merge window. It should make clear
why this is a bug or a regression and why it can't wait until the next
merge window.

Please take this into account for any future patches since Linus now set
a really high bar for patches after the merge window.

Regards

Marcel


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
pull request: wireless-2.6 2008-08-26, John W. Linville, (Tue Aug 26, 6:30 pm)
Re: pull request: wireless-2.6 2008-08-26, Tomas Winkler, (Wed Aug 27, 12:38 am)
Re: pull request: wireless-2.6 2008-08-26, David Miller, (Wed Aug 27, 1:40 am)
Re: pull request: wireless-2.6 2008-08-26, Tomas Winkler, (Wed Aug 27, 2:13 am)
Re: pull request: wireless-2.6 2008-08-26, Tomas Winkler, (Wed Aug 27, 3:05 am)
Re: pull request: wireless-2.6 2008-08-26, Johannes Berg, (Wed Aug 27, 3:10 am)
Re: pull request: wireless-2.6 2008-08-26, David Miller, (Wed Aug 27, 3:32 am)
Re: pull request: wireless-2.6 2008-08-26, David Miller, (Wed Aug 27, 3:33 am)
Re: pull request: wireless-2.6 2008-08-26, Marcel Holtmann, (Wed Aug 27, 4:10 am)
Re: pull request: wireless-2.6 2008-08-26, Tomas Winkler, (Wed Aug 27, 4:34 am)
Re: pull request: wireless-2.6 2008-08-26, David Miller, (Wed Aug 27, 4:39 am)
Re: pull request: wireless-2.6 2008-08-26, Tomas Winkler, (Wed Aug 27, 4:42 am)
Re: pull request: wireless-2.6 2008-08-26, David Miller, (Wed Aug 27, 4:45 am)
Re: pull request: wireless-2.6 2008-08-26, Tomas Winkler, (Wed Aug 27, 5:26 am)
Re: pull request: wireless-2.6 2008-08-26, Michael Buesch, (Wed Aug 27, 6:10 am)
Re: pull request: wireless-2.6 2008-08-26, Arjan van de Ven, (Wed Aug 27, 6:57 am)
Re: pull request: wireless-2.6 2008-08-26, Tomas Winkler, (Wed Aug 27, 7:55 am)
Re: pull request: wireless-2.6 2008-08-26, Michael Buesch, (Wed Aug 27, 8:22 am)
Re: pull request: wireless-2.6 2008-08-26, Tomas Winkler, (Wed Aug 27, 8:45 am)
Re: pull request: wireless-2.6 2008-08-26, Tomas Winkler, (Wed Aug 27, 12:26 pm)
Re: pull request: wireless-2.6 2008-08-26, Michael Buesch, (Wed Aug 27, 1:25 pm)
Re: pull request: wireless-2.6 2008-08-26, Tomas Winkler, (Wed Aug 27, 4:11 pm)
Re: pull request: wireless-2.6 2008-08-26, Luis R. Rodriguez, (Wed Aug 27, 4:31 pm)
Re: pull request: wireless-2.6 2008-08-26, Tomas Winkler, (Wed Aug 27, 5:19 pm)
Re: pull request: wireless-2.6 2008-08-26, Luis R. Rodriguez, (Wed Aug 27, 6:30 pm)
Re: pull request: wireless-2.6 2008-08-26, Tomas Winkler, (Thu Aug 28, 12:59 am)
Re: pull request: wireless-2.6 2008-08-26, Michael Buesch, (Thu Aug 28, 1:31 am)
Re: pull request: wireless-2.6 2008-08-26, Bruno Randolf, (Thu Aug 28, 3:35 am)
Re: pull request: wireless-2.6 2008-08-26, Tomas Winkler, (Thu Aug 28, 3:52 am)
Re: pull request: wireless-2.6 2008-08-26, Bruno Randolf, (Thu Aug 28, 4:13 am)