Re: [Bug #11342] Linux 2.6.27-rc3: kernel BUG at mm/vmalloc.c - bisected

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Tuesday, August 26, 2008 - 7:52 pm

On Tue, 26 Aug 2008, Parag Warudkar wrote:

Umm. Neither is 8k stacks. Nobody "proved" anything.

But yes, some subsystems have insanely deep call chains. And yes, things 
like the VFS recursion (for symlinks) makes that deeper yet for 
filesystems, although only on the lookup path. And that is exactly the 
kind of thing that can exacerbate the problem of the compiler artificially 
making for a bigger stack footprint of a function (*).

For things like the VFS layer, right now we allow a nesting level of 8, I 
think. If I remember correctly, it was 5 historically. Part of raising 
that depth, though, was that we actually moved the recursive part into 
fs/namei.c, and the nesting stack-depth was something pretty damn small 
when the filesystem used "follow_link" properly and let the VFS do it for 
it (ie the callchain to actually look up the link could be deep, but it 
would not recurse back, and instead just return a pointer, so that the 
actual _recursive_ part was just __do_follow_link() and is just a few 
words on the stack).

So yes, we do have some deep callchains, but they tend to be pretty well 
managed for _good_ code. The problems tend to be the areas with lots of 
indirection layers, and yeah, XFS, MD and ACPI all have those kinds of 
things.

In an embdedded world, many of those should be a non-issue, though. 

			Linus

(*) ie the function that _is_ on the deep chain doesn't actually need much 
of a stack footprint at all itself, but it may call a helper function that 
is _not_ in the deep chain, and if it gets inlined it may give its 
excessive stack footprint to the deep chain - and this is _exactly_ the 
problem that happened with inlining "load_module()".
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.27-rc4-git1: Reported regressions from 2.6.26, Rafael J. Wysocki, (Sat Aug 23, 11:07 am)
[Bug #11141] no battery or DC status - Dell i1501, Rafael J. Wysocki, (Sat Aug 23, 11:07 am)
[Bug #11191] 2.6.26-git8: spinlock lockup in c1e_idle(), Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11207] VolanoMark regression with 2.6.27-rc1, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11220] Screen stays black after resume, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11219] KVM modules break emergency reboot, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11215] INFO: possible recursive locking detected ps2 ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11210] libata badness, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11209] 2.6.27-rc1 process time accounting, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11237] corrupt PMD after resume, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11224] Only three cores found on quad-core machine., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11230] Kconfig no longer outputs a .config with fres ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11271] BUG: fealnx in 2.6.27-rc1, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11264] Invalid op opcode in kernel/workqueue, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11254] KVM: fix userspace ABI breakage, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11282] Please fix x86 defconfig regression, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11279] 2.6.27-rc0 Power Bugs with HP/Compaq Laptops, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11276] build error: CONFIG_OPTIMIZE_INLINING=y cause ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11272] BUG: parport_serial in 2.6.27-rc1 for NetMos ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11334] myri10ge: use ioremap_wc: compilation failure ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11336] 2.6.27-rc2:stall while mounting root fs, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11335] 2.6.27-rc2-git5 BUG: unable to handle kernel ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11308] tbench regression on each kernel release from ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11342] Linux 2.6.27-rc3: kernel BUG at mm/vmalloc.c ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11340] LTP overnight run resulted in unusable box, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11343] SATA Cold Boot Problems with 2.6.27-rc[23] on ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11358] net: forcedeth call restore mac addr in nv_sh ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11357] Can not boot up with zd1211rw USB-Wlan Stick, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11356] Linux 2.6.27-rc3 - build failure: undefined r ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11355] Regression in 2.6.27-rc2 when cross-building ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11354] AMD Elan regression with 2.6.27-rc3, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11380] lockdep warning: cpu_add_remove_lock at:cpu_m ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11379] char/tpm: tpm_infineon no longer loaded for H ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11361] my servers with nvidia mcp55 nic don't work w ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11360] mpc8xxx_wdt.c doesn't build modular, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11401] pktcdvd: BUG, NULL pointer dereference in pkt ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11398] hda_intel: IRQ timing workaround is activated ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11388] 2.6.27-rc3 warns about MTRR range; only 3 of ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11382] e1000e: 2.6.27-rc1 corrupts EEPROM/NVM, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11405] 2.6.27-rc3 segfault on cold boot; not on warm ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11403] 2.6.27-rc2 USB suspend regression, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11402] skbuff bug?, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11404] BUG: in 2.6.23-rc3-git7 in do_cciss_intr, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11413] get_rtc_time() triggers NMI watchdog in hpet_ ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11409] build issue #564 for v2.6.27-rc4 : undefined ..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11407] suspend: unable to handle kernel paging request, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11410] SLUB list_lock vs obj_hash.lock..., Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
[Bug #11414] Random crashes with 2.6.27-rc3 on PPC, Rafael J. Wysocki, (Sat Aug 23, 11:10 am)
Re: [Bug #11210] libata badness, Jeff Garzik, (Sat Aug 23, 3:23 pm)
Re: [Bug #11271] BUG: fealnx in 2.6.27-rc1, Jeff Garzik, (Sat Aug 23, 3:26 pm)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Linus Torvalds, (Sun Aug 24, 10:48 am)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Linus Torvalds, (Sun Aug 24, 11:03 am)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Linus Torvalds, (Sun Aug 24, 11:34 am)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Vegard Nossum, (Sun Aug 24, 11:43 am)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Linus Torvalds, (Sun Aug 24, 11:52 am)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Linus Torvalds, (Sun Aug 24, 11:58 am)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Linus Torvalds, (Sun Aug 24, 12:03 pm)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Adrian Bunk, (Sun Aug 24, 12:23 pm)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, David Greaves, (Sun Aug 24, 12:23 pm)
Re: [Bug #11254] KVM: fix userspace ABI breakage, Adrian Bunk, (Sun Aug 24, 12:27 pm)
Re: [Bug #11210] libata badness, Rafael J. Wysocki, (Sun Aug 24, 2:04 pm)
Re: [Bug #11334] myri10ge: use ioremap_wc: compilation fai ..., Rafael J. Wysocki, (Sun Aug 24, 2:05 pm)
Re: [Bug #11356] Linux 2.6.27-rc3 - build failure: undefin ..., Rafael J. Wysocki, (Sun Aug 24, 2:10 pm)
Re: [Bug #11379] char/tpm: tpm_infineon no longer loaded f ..., Rafael J. Wysocki, (Sun Aug 24, 2:12 pm)
Re: [Bug #11355] Regression in 2.6.27-rc2 when cross-build ..., Rafael J. Wysocki, (Sun Aug 24, 2:34 pm)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Rafael J. Wysocki, (Sun Aug 24, 2:40 pm)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, H. Peter Anvin, (Sun Aug 24, 5:16 pm)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Benjamin Herrenschmidt, (Sun Aug 24, 5:48 pm)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Linus Torvalds, (Sun Aug 24, 5:51 pm)
Re: [Bug #11254] KVM: fix userspace ABI breakage, Avi Kivity, (Mon Aug 25, 3:23 am)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Rafael J. Wysocki, (Mon Aug 25, 4:40 am)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Daniel J Blueman, (Mon Aug 25, 6:03 am)
Re: [Bug #11342] Linux 2.6.27-rc3: kernel BUG at mm/vmallo ..., Christoph Lameter, (Mon Aug 25, 3:07 pm)
Re: [Bug #11342] Linux 2.6.27-rc3: kernel BUG at mm/vmallo ..., Linus Torvalds, (Tue Aug 26, 7:52 pm)
Re: [Bug #11342] Linux 2.6.27-rc3: kernel BUG at mm/vmallo ..., Bernd Petrovitsch, (Wed Aug 27, 1:34 am)
Re: [Bug #11342] Linux 2.6.27-rc3: kernel BUG at mm/vmallo ..., Bernd Petrovitsch, (Wed Aug 27, 1:44 am)
Re: [Bug #11342] Linux 2.6.27-rc3: kernel BUG at mm/vmallo ..., Bernd Petrovitsch, (Wed Aug 27, 2:00 am)
Re: [Bug #11342] Linux 2.6.27-rc3: kernel BUG at mm/vmallo ..., Bernd Petrovitsch, (Wed Aug 27, 6:17 am)
Re: [Bug #11342] Linux 2.6.27-rc3: kernel BUG at mm/vmallo ..., Bernd Petrovitsch, (Wed Aug 27, 9:38 am)
Re: [Bug #11342] Linux 2.6.27-rc3: kernel BUG at mm/vmallo ..., Bernd Petrovitsch, (Wed Aug 27, 12:30 pm)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Peter Osterlund, (Wed Aug 27, 1:17 pm)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Linus Torvalds, (Wed Aug 27, 1:40 pm)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Linus Torvalds, (Wed Aug 27, 1:45 pm)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Linus Torvalds, (Wed Aug 27, 3:38 pm)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, David Miller, (Wed Aug 27, 3:43 pm)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Alexey Dobriyan, (Wed Aug 27, 3:45 pm)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Linus Torvalds, (Wed Aug 27, 4:00 pm)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Linus Torvalds, (Wed Aug 27, 4:12 pm)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Linus Torvalds, (Wed Aug 27, 5:35 pm)
Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26, Christoph Hellwig, (Thu Aug 28, 6:52 am)
Subject: [RFC 1/1] cpumask: Provide new cpumask API, Mike Travis, (Thu Sep 25, 1:59 pm)