Re: [PATCH][resubmit] TPM: update char dev BKL pushdown

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Alan Cox
Date: Tuesday, August 26, 2008 - 2:08 pm

> +	atomic_set(&chip->is_open, 1);

Why not just use test_and_set_bit() ? You seem to be abusing atomic_t to
achieve this.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH][resubmit] TPM: update char dev BKL pushdown, Rajiv Andrade, (Tue Aug 26, 1:56 pm)
Re: [PATCH][resubmit] TPM: update char dev BKL pushdown, Alan Cox, (Tue Aug 26, 2:08 pm)
Re: [PATCH][resubmit] TPM: update char dev BKL pushdown, Serge E. Hallyn, (Tue Aug 26, 2:29 pm)
Re: [PATCH][resubmit] TPM: update char dev BKL pushdown, Serge E. Hallyn, (Tue Aug 26, 8:19 pm)
Re: [PATCH][resubmit] TPM: update char dev BKL pushdown, Rajiv Andrade, (Wed Aug 27, 7:32 am)