login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
August
»
26
Re: [PATCH 2/2] rcu: fix sparse shadowed variable warning
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: Paul E. McKenney
Subject:
Re: [PATCH 2/2] rcu: fix sparse shadowed variable warning
Date: Tuesday, August 26, 2008 - 1:43 pm
On Tue, Aug 26, 2008 at 01:00:44PM -0700, Harvey Harrison wrote:
quoted text
> kernel/rcuclassic.c:564:18: warning: symbol 'flags' shadows an earlier one > kernel/rcuclassic.c:527:16: originally declared here
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
quoted text
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> > --- > It would be safe in this case to just remove the second declaration of flags > and reuse it as it is outside the local_irq_save/restore pair. I did it this > way in case there are future changes that might mix up the use of flags. > > Feel free to just remove the second flags declaration if you'd rather do it > that way. > > kernel/rcuclassic.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/kernel/rcuclassic.c b/kernel/rcuclassic.c > index 743cf05..ed15128 100644 > --- a/kernel/rcuclassic.c > +++ b/kernel/rcuclassic.c > @@ -561,15 +561,15 @@ static void __rcu_process_callbacks(struct rcu_ctrlblk *rcp, > local_irq_restore(flags); > > if (rcu_batch_after(rdp->batch, rcp->pending)) { > - unsigned long flags; > + unsigned long flags2; > > /* and start it/schedule start if it's a new batch */ > - spin_lock_irqsave(&rcp->lock, flags); > + spin_lock_irqsave(&rcp->lock, flags2); > if (rcu_batch_after(rdp->batch, rcp->pending)) { > rcp->pending = rdp->batch; > rcu_start_batch(rcp); > } > - spin_unlock_irqrestore(&rcp->lock, flags); > + spin_unlock_irqrestore(&rcp->lock, flags2); > } > } > > -- > 1.6.0.340.g84854 >
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH 2/2] rcu: fix sparse shadowed variable warning
, Harvey Harrison
, (Tue Aug 26, 1:00 pm)
Re: [PATCH 2/2] rcu: fix sparse shadowed variable warning
, Paul E. McKenney
, (Tue Aug 26, 1:43 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Paul Turner
[tg_shares_up rewrite v2 11/11] sched: update tg->shares after cpu.shares write
Ingo Molnar
Re: [RFC] Cpu-hotplug: Using the Process Freezer (try2)
Michal Nazarewicz
Re: [PATCH] USB: Gadget: g_multi: added INF file for gadget with multiple configur...
Eric W. Biederman
Re: init's children list is long and slows reaping children.
Jeffrey V. Merkey
Re: Versioning file system
git
:
Matthieu Moy
Re: Bugs in Gitosis
Daniel Barkalow
Re: About git and the use of SHA-1
David Lang
Re: mingw, windows, crlf/lf, and git
Shawn O. Pearce
Re: Bugs in Gitosis
Junio C Hamano
Re: [PATCH 14/21] Convert ce_path_match() to use struct pathspec
linux-netdev
:
David Miller
Re: [2.6.30-rc3] powerpc: compilation error of mace module
David Miller
Re: [PATCH] ipv6: fix display of local and remote sit endpoints
Cong Wang
Re: [PATCH] s2io: add dynamic LRO disable support
Tobacco New Year Promo
Eric Dumazet
Re: [PATCH] net: implement emergency route cache rebulds when gc_elasticity is exc...
git-commits-head
:
Linux Kernel Mailing List
V4L/DVB: tm6000: add special usb request to quit i2c tuner transfer
Linux Kernel Mailing List
of/flattree: merge early_init_dt_scan_memory() common code
Linux Kernel Mailing List
b43: N-PHY: add some registers and structs definitions
Linux Kernel Mailing List
powerpc: Move /proc/ppc64 to /proc/powerpc and add symlink
Linux Kernel Mailing List
drivers/acpi: use kasprintf
openbsd-misc
:
Ted Bullock
Re: Proliant DL380 G3 cannot get on network
Eric Furman
Re: Defending OpenBSD Performance
Damien Miller
Re: Patching a SSH 'Weakness'
Tony Abernethy
Re: The Atheros story in much fewer words
Nick Holland
Re: 1 out of 3 hunks failed--saving rejects to kerberosV/src/lib/krb5/crypto.c.rej
Colocation donated by:
Syndicate