Re: [PATCH 2/2] smp_call_function: use rwlocks on queues rather than rcu

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <paulmck@...>
Cc: Christoph Lameter <cl@...>, Pekka Enberg <penberg@...>, Ingo Molnar <mingo@...>, Jeremy Fitzhardinge <jeremy@...>, Nick Piggin <nickpiggin@...>, Andi Kleen <andi@...>, Pallipadi, Venkatesh <venkatesh.pallipadi@...>, Suresh Siddha <suresh.b.siddha@...>, Jens Axboe <jens.axboe@...>, Rusty Russell <rusty@...>, Linux Kernel Mailing List <linux-kernel@...>
Date: Monday, August 25, 2008 - 11:22 am

On Mon, 2008-08-25 at 08:12 -0700, Paul E. McKenney wrote:

If we combine these two cases, and flip the counter as soon as we've
enqueued one callback, unless we're already waiting for a grace period
to end - which gives us a longer window to collect callbacks.

And then the rcu_read_unlock() can do:

  if (dec_and_zero(my_counter) && my_index == dying)
    raise_softirq(RCU)

to fire off the callback stuff.

/me ponders - there must be something wrong with that...

Aaah, yes, the dec_and_zero is non trivial due to the fact that its a
distributed counter. Bugger..

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 2/2] smp_call_function: use rwlocks on queues rather ..., Jeremy Fitzhardinge, (Thu Aug 21, 8:29 pm)
Re: [PATCH 2/2] smp_call_function: use rwlocks on queues rat..., Christoph Lameter, (Fri Aug 22, 10:01 am)
Re: [PATCH 2/2] smp_call_function: use rwlocks on queues rat..., Paul E. McKenney, (Fri Aug 22, 11:11 am)
Re: [PATCH 2/2] smp_call_function: use rwlocks on queues rat..., Christoph Lameter, (Fri Aug 22, 1:14 pm)
Re: [PATCH 2/2] smp_call_function: use rwlocks on queues rat..., Christoph Lameter, (Fri Aug 22, 2:36 pm)
Re: [PATCH 2/2] smp_call_function: use rwlocks on queues rat..., Christoph Lameter, (Fri Aug 22, 4:03 pm)
Re: [PATCH 2/2] smp_call_function: use rwlocks on queues rat..., Paul E. McKenney, (Mon Aug 25, 11:12 am)
Re: [PATCH 2/2] smp_call_function: use rwlocks on queues rat..., Christoph Lameter, (Mon Aug 25, 11:44 am)
Re: [PATCH 2/2] smp_call_function: use rwlocks on queues rat..., Peter Zijlstra, (Mon Aug 25, 11:22 am)
Re: [PATCH 2/2] smp_call_function: use rwlocks on queues rat..., Christoph Lameter, (Mon Aug 25, 11:46 am)
Re: [PATCH 2/2] smp_call_function: use rwlocks on queues rat..., Paul E. McKenney, (Wed Aug 27, 11:16 am)
Re: [PATCH 2/2] smp_call_function: use rwlocks on queues rat..., Jeremy Fitzhardinge, (Fri Aug 22, 2:35 pm)
Re: [PATCH 2/2] smp_call_function: use rwlocks on queues rat..., Jeremy Fitzhardinge, (Sun Aug 24, 12:55 am)