Home » Mailing list archives » linux-kernel » 2008 » August » 25

Re: [PATCH] Fix emergency_restart (sysrq-b) with kvm loaded on Intel hosts

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Eric W. Biederman
Subject: Re: [PATCH] Fix emergency_restart (sysrq-b) with kvm loaded on Intel hosts
Date: Monday, August 25, 2008 - 6:14 am

Ingo Molnar <mingo@elte.hu> writes:


Please no notifiers in emergency_restart.

First emergency_restart is not supposed to work reliably it is a best effort tickle
the hardware thing.

Second and more importantly whenever someone adds a notifier instead of a proper hook
to one a code path like this it seems like avoiding building a proper interface so
and I believe keeps us from getting all of the logic and the heuristics right.

Why not just add a disable intel_vt if it is enabled call?

Eric
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Fix emergency_restart (sysrq-b) with kvm loaded on ..., Avi Kivity, (Mon Aug 25, 2:11 am)
Re: [PATCH] Fix emergency_restart (sysrq-b) with kvm loade ..., Ingo Molnar, (Mon Aug 25, 2:15 am)
Re: [PATCH] Fix emergency_restart (sysrq-b) with kvm loade ..., Avi Kivity, (Mon Aug 25, 2:27 am)
Re: [PATCH] Fix emergency_restart (sysrq-b) with kvm loade ..., Ingo Molnar, (Mon Aug 25, 2:30 am)
Re: [PATCH] Fix emergency_restart (sysrq-b) with kvm loade ..., Avi Kivity, (Mon Aug 25, 3:03 am)
Re: [PATCH] Fix emergency_restart (sysrq-b) with kvm loade ..., Ingo Molnar, (Mon Aug 25, 3:27 am)
Re: [PATCH] Fix emergency_restart (sysrq-b) with kvm loade ..., Avi Kivity, (Mon Aug 25, 3:36 am)
Re: [PATCH] Fix emergency_restart (sysrq-b) with kvm loade ..., Eric W. Biederman, (Mon Aug 25, 6:12 am)
Re: [PATCH] Fix emergency_restart (sysrq-b) with kvm loade ..., Eric W. Biederman, (Mon Aug 25, 6:14 am)
Re: [PATCH] Fix emergency_restart (sysrq-b) with kvm loade ..., Avi Kivity, (Mon Aug 25, 6:35 am)