UML Reboot Panic

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: lkml <linux-kernel@...>, Jeff Dike <jdike@...>
Date: Sunday, August 24, 2008 - 4:49 pm

Hi,

When using UML with a UML block device, and issuing a reboot, I was
getting a kernel panic on the next kernel startup because UML was
unable to open the file mapped to the UBD.  I think this is because
the file is not closed when the UBD is released, and the following
patch appears to resolve this issue.  I'm not sure if it's the right
fix, as I may have missed something, but it works for me.

-- Tom

diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index b58fb89..946a171 100644
--- a/arch/um/drivers/ubd_kern.c
+++ b/arch/um/drivers/ubd_kern.c
@@ -802,6 +802,7 @@ static void ubd_device_release(struct device *dev)
        struct ubd *ubd_dev = dev->driver_data;

        blk_cleanup_queue(ubd_dev->queue);
+       os_close_file(ubd_dev->fd);
        *ubd_dev = ((struct ubd) DEFAULT_UBD);
 }
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
UML Reboot Panic, Tom Spink, (Sun Aug 24, 4:49 pm)
Re: UML Reboot Panic, Jeff Dike, (Mon Aug 25, 6:11 pm)