On Sun, 24 Aug 2008, Al Viro wrote:
quoted text
> 
> One obvious note: that'll break old_readdir() on coda.  There you need to
> change the existing check (you need to check buf.result, then ignore error
> unless buf.result ended up 0).

Hmm? old_readdir() was the only one that I didn't change, because it 
didn't need changing. It already ignores the return value of 
"vfs_readdir()" entirely if it is positive or zero, and takes it from 
buf.result.

So old_readdir() literally doesn't care at all (and never has) whether a 
->readdir() function returns zero or a positive number. So changing coda 
readdir() it to return zero _instead_ of a positive number makes 
absolutely zero difference: old_readdir() will do the same thing 
regardless.

What am I missing?

		Linus
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/