Re: V4L2: switch to register_chrdev_region: needs testing/review of release() handling

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Laurent Pinchart
Date: Saturday, August 23, 2008 - 7:01 am

Hi Hans,

On Sunday 17 August 2008, Hans Verkuil wrote:

I've given your patch a try on 2.6.27-rc4 with the uvcvideo driver. Nothing 
seems to have been broken so far, and the uvcvideo driver got a bit simpler 
as I've been able to get rid of the refcounting logic. Good job.

Do we really need the double refcounting (class device and character device) ? 
As far as I can tell, the class device is only used for the name and index 
sysfs attributes. Its release callback, video_release, is called as soon as 
video_unregister_device drops its reference to the class device, even when 
sysfs files are still opened.

Best regards,

Laurent Pinchart
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: V4L2: switch to register_chrdev_region: needs testing/ ..., David Ellingsworth, (Sun Aug 17, 3:27 pm)
Re: V4L2: switch to register_chrdev_region: needs testing/ ..., Laurent Pinchart, (Sat Aug 23, 7:01 am)