[PATCH] ath9k: add harmlessly-omitted braces

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jim Meyering
Date: Friday, August 22, 2008 - 11:49 pm

---
Alternatively, you could remove the nowadays-useless
"if-before-kfree" test and leave the sometimes-redundant
assignment as-is: unconditional.

 drivers/net/wireless/ath9k/main.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath9k/main.c b/drivers/net/wireless/ath9k/main.c
index 2888778..21bef29 100644
--- a/drivers/net/wireless/ath9k/main.c
+++ b/drivers/net/wireless/ath9k/main.c
@@ -1056,9 +1056,10 @@ void ath_tx_complete(struct ath_softc *sc, struct sk_buff *skb,
 	if (tx_info->flags & IEEE80211_TX_CTL_NO_ACK ||
 		tx_info->flags & IEEE80211_TX_STAT_TX_FILTERED) {
 		/* free driver's private data area of tx_info */
-		if (tx_info->driver_data[0] != NULL)
+		if (tx_info->driver_data[0] != NULL) {
 			kfree(tx_info->driver_data[0]);
 			tx_info->driver_data[0] = NULL;
+		}
 	}

 	if (tx_status->flags & ATH_TX_BAR) {
--
1.6.0.90.g436ed
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] ath9k: add harmlessly-omitted braces, Jim Meyering, (Fri Aug 22, 11:49 pm)
Re: [PATCH] ath9k: add harmlessly-omitted braces, Marcel Holtmann, (Sat Aug 23, 3:02 am)