On Friday 22 August 2008, Alan Stern wrote:
quoted text > On Fri, 22 Aug 2008, Andrey Borzenkov wrote:
>=20
> > It looks even funnier. Right now I am running with commits
> > 38b375d9610e2467cb793a84d17c6f65e44cdb39 *and*
> > e872154921a6b5256a3c412dd69158ac0b135176 reverted. I.e. this should be
> > the state which hopelessly failed in 2.6.26-rc. It seems to be doing
> > quite well now in 2.6.27-rc.
> >=20
> > "git revert e872154921a6b5256a3c412dd69158ac0b135176" gives me this
> > one liner patch:
> >=20
> > commit f3cf9ad86ee76077d1c6be9af7d197aa13ccdff9
> > Author: Andrey Borzenkov <arvidjaar@mail.ru>
> > Date: Fri Aug 22 21:15:26 2008 +0400
> >=20
> > Revert "USB: don't explicitly reenable root-hub status interrupts"
> >=20
> > This reverts commit e872154921a6b5256a3c412dd69158ac0b135176.
> >=20
> > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> > index 107e1d2..d30f822 100644
> > --- a/drivers/usb/core/hub.c
> > +++ b/drivers/usb/core/hub.c
> > @@ -3086,6 +3086,11 @@ static void hub_events(void)
> > if (!hdev->parent && !hub->busy_bits[0])
> > usb_enable_root_hub_irq(hdev->bus);
> >=20
> > + /* If this is a root hub, tell the HCD it's okay to
> > + * re-enable port-change interrupts now. */
> > + if (!hdev->parent && !hub->busy_bits[0])
> > + usb_enable_root_hub_irq(hdev->bus);
> > +
> > loop_autopm:
> > /* Allow autosuspend if we're not going to run again */
> > if (list_empty(&hub->event_list))
> >=20
> > Either my git tree is completely botched or most parts were already rev=
erted
quoted text > > before.
>=20
> _Something_ is completely botched. e872154 is much bigger than what=20
> you quoted above.
>=20
Oh, no need to be *that* polite telling me I'm idiot.
quoted text > The commit you really want to revert is
> 09ca8adbe9f724a7e96f512c0039c4c4a1c5dcc0.
>=20
Sure. Mouse slipped doing copy'n'paste :)
If you are still interested in this strange effect of lone 38b375d9,
I could run some tests; just tell me what is needed.
