login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
August
»
22
Re: [PATCH] genirq: irq_chip->startup() usage in setup_irq and set_irq_chained handler
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Pawel MOLL <pawel.moll@...>
To: Ingo Molnar <mingo@...>
Cc: <linux-kernel@...>, Pawel Moll <pawel.moll@...>
Subject:
Re: [PATCH] genirq: irq_chip->startup() usage in setup_irq and set_irq_chained handler
Date: Friday, August 22, 2008 - 10:49 am
Hi, Ingo, Apparently I have swapped To: and Cc: field in the original mail, apologies.
quoted text
> This patch clarifies a usage of irq_chip->startup() callback: > > 1. The "if (startup) startup(); else enabled();" code in setup_irq() > is unnecessary, as startup() falls back to enabled() via > default callbacks, set by irq_chip_set_defaults(). > > 2. When using set_irq_chained_handler() the startup() was never called, > which is not good at all... Fixed. And again - when startup() is not > defined the call will fall back to enable() than to unmask() via > default callbacks.
Any comment on the patch? Best regards Paweł --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] genirq: irq_chip->startup() usage in setup_irq an...
, Pawel MOLL
, (Thu Aug 21, 6:14 am)
Re: [PATCH] genirq: irq_chip->startup() usage in setup_ir...
, Pawel MOLL
, (Fri Aug 22, 10:49 am)
Re: [PATCH] genirq: irq_chip->startup() usage in setup_ir...
, Ingo Molnar
, (Sat Aug 23, 12:08 pm)
Re: [PATCH] genirq: irq_chip->startup() usage in setup_ir...
, Benjamin Herrenschmidt
, (Sat Aug 23, 6:43 pm)
Re: [PATCH] genirq: irq_chip->startup() usage in setup_ir...
, Pawel MOLL
, (Tue Aug 26, 6:14 am)
Re: [PATCH] genirq: irq_chip->startup() usage in setup_ir...
, Benjamin Herrenschmidt
, (Tue Aug 26, 8:06 pm)
Re: [PATCH] genirq: irq_chip->startup() usage in setup_ir...
, Pawel MOLL
, (Mon Sep 1, 4:47 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg Kroah-Hartman
[PATCH 002/196] Chinese: rephrase English introduction in HOWTO
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Amit K. Arora
[RFC] Heads up on sys_fallocate()
Linus Torvalds
Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes g...
git
:
linux-netdev
:
David Miller
[GIT]: Networking
Jarek Poplawski
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Ray Lee
Re: [BUG] New Kernel Bugs
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
1 user
and
569 guests
online.
Online users
hotpicks
Syndicate