login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
August
»
21
Re: [PATCH] Xen: Fix warning when hot-unplugging virtual block devices
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: Jeremy Fitzhardinge
Subject:
Re: [PATCH] Xen: Fix warning when hot-unplugging virtual block devices
Date: Thursday, August 21, 2008 - 1:13 pm
Alex Nixon wrote:
quoted text
> From: Alex Nixon <alex.nixon@citrix.com> > Date: Thu, 21 Aug 2008 12:30:54 +0100 > Subject: [PATCH] Xen: Fix warning when hot-unplugging virtual block devices > > WARNING: at kernel/softirq.c:136 local_bh_enable+0x3f/0x8a() > > del_gendisk needs IRQs enabled, as the code path eventually reaches local_bh_enable. > blk_stop_queue needs them disabled - so do so temporarily. > > It shouldn't matter if an interrupt comes in whilst blkif_io_lock is held, as it will block on the lock. Upon acquisition, it'll realise the device is down and exit cleanly. > > Signed-off-by: Alex Nixon <alex.nixon@citrix.com> >
Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> Send a clean copy to Jens with my ack. J
quoted text
> --- > drivers/block/xen-blkfront.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c > index d5e7532..95cee2c 100644 > --- a/drivers/block/xen-blkfront.c > +++ b/drivers/block/xen-blkfront.c > @@ -899,16 +899,18 @@ static void blkfront_closing(struct xenbus_device *dev) > if (info->rq == NULL) > goto out; > > - spin_lock_irqsave(&blkif_io_lock, flags); > + spin_lock(&blkif_io_lock); > > del_gendisk(info->gd); > > + local_irq_save(flags); > /* No more blkif_request(). */ > blk_stop_queue(info->rq); > + local_irq_restore(flags); > > /* No more gnttab callback work. */ > gnttab_cancel_free_callback(&info->callback); > - spin_unlock_irqrestore(&blkif_io_lock, flags); > + spin_unlock(&blkif_io_lock); > > /* Flush gnttab callback work. Must be done with no locks held. */ > flush_scheduled_work(); >
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] Xen: Fix warning when hot-unplugging virtual block ...
, Alex Nixon
, (Thu Aug 21, 4:37 am)
Re: [PATCH] Xen: Fix warning when hot-unplugging virtual b ...
, Jeremy Fitzhardinge
, (Thu Aug 21, 1:13 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Rafael J. Wysocki
[Bug #11409] build issue #564 for v2.6.27-rc4 : undefined reference to `NS8390p_in...
Greg Kroah-Hartman
[PATCH 20/36] Driver core: Call device_pm_add() after bus_add_device() in device_a...
Andrew Morton
2.6.23-rc6-mm1
Con Kolivas
Re: [PATCH] sched: staircase deadline misc fixes
Jeremy Fitzhardinge
[PATCH 33 of 36] x86_64: ia32entry: replace privileged instructions with pvops
linux-netdev
:
Daniel Lezcano
getsockopt(TCP_DEFER_ACCEPT) value change
David Miller
Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
Ingo Molnar
Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference
Gerrit Renker
[PATCH 37/37] dccp: Debugging functions for feature negotiation
Jeff Garzik
Re: [PATCH] drivers/net: remove network drivers' last few uses of IRQF_SAMPLE_RANDOM
git
:
Junio C Hamano
Re: git-svnimport
Anuj Gakhar
Git Architecture Question
Johannes Schindelin
Re: [PATCH] Fix approxidate("never") to always return 0
A Large Angry SCM
Re: [RFC] origin link for cherry-pick and revert
Gabriel
[PATCH] When a remote is added but not fetched, tell the user.
openbsd-misc
:
Jason Dixon
Re: any web management gui for pf ?
Christophe Rioux
Implementation example of snmp
Nick Holland
Re: booting openbsd on eee without cd-rom
Bryan Irvine
Re: OpenBSD 4.7 Released, May 19 2010
Marco Peereboom
Re: Singularity OS
linux-kvm
:
Harald Braumann
Windows guest freezes with black screen
Huang Ying
Re: [PATCH] Ignore SRAO MCE if another MCE is being processed
Alex Williamson
Re: [RFC PATCH 5/6] savevm: Migrate RAM based on name/offset
Alexander Graf
[PATCH 23/27] KVM: PPC: PV assembler helpers
Anthony Liguori
Re: [Qemu-devel] [PATCH] Vmchannel PCI device.
Colocation donated by:
Syndicate