[PATCH] x86: fix probe_nr_irqs for xen

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>, Thomas Gleixner <tglx@...>, H. Peter Anvin <hpa@...>, Andrew Morton <akpm@...>
Cc: <linux-kernel@...>, Yinghai Lu <yhlu.kernel@...>, Alex Nixon <alex.nixon@...>
Date: Thursday, August 21, 2008 - 4:10 pm

otherwise Xen is _completely_ unusable with 5 or more VCPUs.
( when !CONFIG_HAVE_SPARSE_IRQ)

based on Alex's patch

also add +1 offset after redir_entries

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Alex Nixon <alex.nixon@citrix.com>

Index: linux-2.6/arch/x86/kernel/io_apic.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/io_apic.c
+++ linux-2.6/arch/x86/kernel/io_apic.c
@@ -3625,16 +3625,21 @@ int __init probe_nr_irqs(void)
 {
 	int idx;
 	int nr = 0;
+#ifndef CONFIG_XEN
+	int nr_min = 32;
+#else
+	int nr_min = NR_IRQS;
+#endif
 
 	for (idx = 0; idx < nr_ioapics; idx++)
-		nr += io_apic_get_redir_entries(idx);
+		nr += io_apic_get_redir_entries(idx) + 1;
 
 	/* double it for hotplug and msi and nmi */
 	nr <<= 1;
 
 	/* something wrong ? */
-	if (nr < 32)
-		nr = 32;
+	if (nr < nr_min)
+		nr = nr_min;
 
 	return nr;
 }
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] x86: fix probe_nr_irqs for xen, Yinghai Lu, (Thu Aug 21, 4:10 pm)
Re: [PATCH] x86: fix probe_nr_irqs for xen, Jeremy Fitzhardinge, (Thu Aug 21, 7:33 pm)
Re: [PATCH] x86: fix probe_nr_irqs for xen, Ingo Molnar, (Fri Aug 22, 12:28 am)
Re: [PATCH] x86: fix probe_nr_irqs for xen, Alex Nixon, (Fri Aug 22, 5:07 am)
Re: [PATCH] x86: fix probe_nr_irqs for xen, Yinghai Lu, (Thu Aug 21, 7:49 pm)
Re: [PATCH] x86: fix probe_nr_irqs for xen, Jeremy Fitzhardinge, (Thu Aug 21, 7:52 pm)
Re: [PATCH] x86: fix probe_nr_irqs for xen, Yinghai Lu, (Thu Aug 21, 7:56 pm)
Re: [PATCH] x86: fix probe_nr_irqs for xen, Jeremy Fitzhardinge, (Thu Aug 21, 8:02 pm)
Re: [PATCH] x86: fix probe_nr_irqs for xen, Ingo Molnar, (Fri Aug 22, 12:26 am)
Re: [PATCH] x86: fix probe_nr_irqs for xen, Yinghai Lu, (Fri Aug 22, 1:06 am)
Re: [PATCH] x86: fix probe_nr_irqs for xen, Ingo Molnar, (Fri Aug 22, 1:16 am)
Re: [PATCH] x86: fix probe_nr_irqs for xen, Cyrill Gorcunov, (Fri Aug 22, 9:44 am)
Re: [PATCH] x86: fix probe_nr_irqs for xen, Yinghai Lu, (Thu Aug 21, 8:27 pm)