[PATCH 15/15] pnp: fix "add acpi:* modalias entries"

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>
Cc: Kay Sievers <kay.sievers@...>, Greg Kroah-Hartman <gregkh@...>
Date: Thursday, August 21, 2008 - 1:33 pm

From: Kay Sievers <kay.sievers@vrfy.org>

With 22454cb99fc39f2629ad06a7eccb3df312f8830e we added only the
first entry of the device table. We need to loop over the whole
device list.

Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 scripts/mod/file2alias.c |   16 +++++++++++-----
 1 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
index 4fa1f3a..4c9890e 100644
--- a/scripts/mod/file2alias.c
+++ b/scripts/mod/file2alias.c
@@ -344,14 +344,20 @@ static void do_pnp_device_entry(void *symval, unsigned long size,
 				struct module *mod)
 {
 	const unsigned long id_size = sizeof(struct pnp_device_id);
-	const struct pnp_device_id *id = symval;
+	const unsigned int count = (size / id_size)-1;
+	const struct pnp_device_id *devs = symval;
+	unsigned int i;
 
 	device_id_check(mod->name, "pnp", size, id_size, symval);
 
-	buf_printf(&mod->dev_table_buf,
-		   "MODULE_ALIAS(\"pnp:d%s*\");\n", id->id);
-	buf_printf(&mod->dev_table_buf,
-		   "MODULE_ALIAS(\"acpi*:%s:*\");\n", id->id);
+	for (i = 0; i < count; i++) {
+		const char *id = (char *)devs[i].id;
+
+		buf_printf(&mod->dev_table_buf,
+			   "MODULE_ALIAS(\"pnp:d%s*\");\n", id);
+		buf_printf(&mod->dev_table_buf,
+			   "MODULE_ALIAS(\"acpi*:%s:*\");\n", id);
+	}
 }
 
 /* looks like: "pnp:dD" for every device of the card */
-- 
1.5.6.5

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 15/15] pnp: fix "add acpi:* modalias entries", Greg Kroah-Hartman, (Thu Aug 21, 1:33 pm)
[PATCH 14/15] UIO: generic irq handling for some uio platfor..., Greg Kroah-Hartman, (Thu Aug 21, 1:33 pm)
[PATCH 13/15] UIO: uio_pdrv: fix license specification, Greg Kroah-Hartman, (Thu Aug 21, 1:33 pm)
[PATCH 12/15] UIO: uio_pdrv: fix memory leak, Greg Kroah-Hartman, (Thu Aug 21, 1:33 pm)
[PATCH 11/15] block: drop references taken by class_find_dev..., Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 10/15] block: fix partial read() of /proc/{partitions..., Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 09/15] PM: Remove WARN_ON from device_pm_add, Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 08/15] driver core: add init_name to struct device, Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 07/15] PM: don't skip device PM init when CONFIG_PM_S..., Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 06/15] driver model: anti-oopsing medicine, Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
Re: [PATCH 06/15] driver model: anti-oopsing medicine, David Brownell, (Thu Aug 21, 2:24 pm)
[PATCH 05/15] dev_printk(): constify the `dev' argument, Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 04/15] drivers/base/driver.c: remove unused to_dev() ..., Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 03/15] Documentation: HOWTO-ja_JP-sync patch, Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 02/15] Japanese translation of Documentation/SubmitCh..., Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 01/15] kobject: Replace ALL occurrences of '/' with '..., Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)